Support autocompletion for HTMl5 tags:"email", "month" and "tel".

chrome/renderer/form_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/form_manager.h"
 
 #include "base/logging.h"
 #include "base/scoped_vector.h"
 #include "base/string_util.h"
 #include "base/stl_util-inl.h"
@@ skipping 255 matching lines @@
     // For select-one elements copy option strings.
     WebVector<WebElement> list_items = select_element.listItems();
     option_strings->reserve(list_items.size());
     for (size_t i = 0; i < list_items.size(); ++i) {
       if (list_items[i].hasTagName("option"))
         option_strings->push_back(list_items[i].to<WebOptionElement>().value());
     }
   }
 }
 
+// In HTML5, email, all text fields except password are text input fields to

[Ilya Sherman, 2011/01/10 20:08:48]

nit: I think the fragment "email, " in this sentence is left over from a
previous comment ;)

[honten.org, 2011/01/25 05:19:24]

Done.

+// autocomplete.
+static bool IsTextInput(const WebInputElement& element) {
+  return element.isTextField() && !element.isPasswordField();
+}
+
 }  // namespace
 
 struct FormManager::FormElement {
   WebKit::WebFormElement form_element;
   std::vector<WebKit::WebFormControlElement> control_elements;
   std::vector<string16> control_values;
 };
 
 FormManager::FormManager() {
 }
@@ skipping 15 matching lines @@
   field->set_name(element.nameForAutofill());
   field->set_form_control_type(element.formControlType());
 
   if (extract_mask & EXTRACT_OPTIONS) {
     // Set option strings on the field if available.
     std::vector<string16> option_strings;
     GetOptionStringsFromElement(element, &option_strings);
     field->set_option_strings(option_strings);
   }
 
-  if (element.formControlType() == WebString::fromUTF8("text")) {
-    const WebInputElement& input_element = element.toConst<WebInputElement>();
+  const WebInputElement& input_element = element.toConst<WebInputElement>();

[Ilya Sherman, 2011/01/10 20:08:48]

I might be mistaken, but I think this conversion will fail for <select>
elements, and potentially others as well.  I'll try to remember to take another
look at this when I get back into the office on Monday.

[Ilya Sherman, 2011/01/10 21:08:37]

Yep, this conversion is just a static_cast, which is not guaranteed to work
here.

In the realm of WebKit, it looks like dom/InputElement::toInputElement() is the
typesafe way to perform this conversion.  I don't think we have something like
this exported in the Chromium WebKit API.  Darin Fisher (fishd) might be a good
person to ask about whether this already exists; or if not, where to add it.

[honten.org, 2011/01/10 22:50:35]

Ok, I'll ask him.

On 2011/01/10 21:08:37, Ilya Sherman wrote:

[honten.org, 2011/01/10 22:57:13]

Darin,

Could you tell me if there is a method Ilya mentions here?

If there is not, do you have any suggestion or thought?

Thanks,

On 2011/01/10 22:50:35, honten wrote:

[dhollowa, 2011/01/19 18:49:45]

The test: element.hasTagName("input") should be sufficient to safely test that
the downcast is ok.

On 2011/01/10 22:57:13, honten wrote:

[darin (slow to review), 2011/01/19 22:04:18]

I think you can use WebElement::hasTagName("input") to check if casting to
WebInputElement is valid.

However, it would probably be better if we had a way to leverage
toInputElement().

I support adding a toWebInputElement method in WebInputElement.h.  If we do
that, we should also do the same for all of the other WebNode subclasses.

[honten.org, 2011/01/25 05:19:24]

Now I changed to use toWebInputElement().

On 2011/01/19 22:04:18, darin wrote:

+  if (IsTextInput(input_element)) {
     field->set_max_length(input_element.maxLength());
     field->set_autofilled(input_element.isAutofilled());
   }
 
   if (!(extract_mask & EXTRACT_VALUE))
     return;
 
   // TODO(jhawkins): In WebKit, move value() and setValue() to
   // WebFormControlElement.
   string16 value;
-  if (element.formControlType() == WebString::fromUTF8("text") ||
+  if (IsTextInput(input_element) ||
       element.formControlType() == WebString::fromUTF8("hidden")) {
     const WebInputElement& input_element =
         element.toConst<WebInputElement>();
     value = input_element.value();
   } else if (element.formControlType() == WebString::fromUTF8("select-one")) {
     // TODO(jhawkins): This is ugly.  WebSelectElement::value() is a non-const
     // method.  Look into fixing this on the WebKit side.
     WebFormControlElement& e = const_cast<WebFormControlElement&>(element);
     WebSelectElement select_element = e.to<WebSelectElement>();
     value = select_element.value();
@@ skipping 76 matching lines @@
   WebVector<WebFormControlElement> control_elements;
   element.getFormControlElements(control_elements);
 
   // A vector of bools that indicate whether each field in the form meets the
   // requirements and thus will be in the resulting |form|.
   std::vector<bool> fields_extracted(control_elements.size(), false);
 
   for (size_t i = 0; i < control_elements.size(); ++i) {
     const WebFormControlElement& control_element = control_elements[i];
 
+    const WebInputElement& controll_input_element =
+        control_element.toConst<WebInputElement>();

[Ilya Sherman, 2011/01/10 20:08:48]

nit: If this conversion is legal (see above), you should just call this
|input_element| and remove the declaration of |input_element| within the
if-stmt.

     if (requirements & REQUIRE_AUTOCOMPLETE &&
-        control_element.formControlType() == WebString::fromUTF8("text")) {
+        IsTextInput(controll_input_element)) {
       const WebInputElement& input_element =
           control_element.toConst<WebInputElement>();
       if (!input_element.autoComplete())
         continue;
     }
 
     if (requirements & REQUIRE_ENABLED && !control_element.isEnabled())
       continue;
 
     // Create a new FormField, fill it out and map it to the field's name.
@@ skipping 192 matching lines @@
   return true;
 }
 
 bool FormManager::ClearFormWithNode(const WebNode& node) {
   FormElement* form_element = NULL;
   if (!FindCachedFormElementWithNode(node, &form_element))
     return false;
 
   for (size_t i = 0; i < form_element->control_elements.size(); ++i) {
     WebFormControlElement element = form_element->control_elements[i];
-    if (element.formControlType() == WebString::fromUTF8("text")) {
-
-      WebInputElement input_element = element.to<WebInputElement>();
+    WebInputElement input_element = element.to<WebInputElement>();
+    if (IsTextInput(input_element)) {
 
       // We don't modify the value of disabled fields.
       if (!input_element.isEnabled())
         continue;
 
       input_element.setValue(string16());
       input_element.setAutofilled(false);
 
       // Clearing the value in the focused node (above) can cause selection
       // to be lost. We force selection range to restore the text cursor.
@@ skipping 11 matching lines @@
 }
 
 bool FormManager::ClearPreviewedFormWithNode(const WebNode& node,
                                              bool was_autofilled) {
   FormElement* form_element = NULL;
   if (!FindCachedFormElementWithNode(node, &form_element))
     return false;
 
   for (size_t i = 0; i < form_element->control_elements.size(); ++i) {
     WebFormControlElement* element = &form_element->control_elements[i];
-
+    WebInputElement input_element = element->to<WebInputElement>();
     // Only input elements can be previewed.
-    if (element->formControlType() != WebString::fromUTF8("text"))
+    if (!IsTextInput(input_element))
       continue;
 
     // If the input element has not been auto-filled, FormManager has not
     // previewed this field, so we have nothing to reset.
-    WebInputElement input_element = element->to<WebInputElement>();
     if (!input_element.isAutofilled())
       continue;
 
     // There might be unrelated elements in this form which have already been
     // auto-filled. For example, the user might have already filled the address
     // part of a form and now be dealing with the credit card section. We only
     // want to reset the auto-filled status for fields that were previewed.
     if (input_element.suggestedValue().isEmpty())
       continue;
 
@@ skipping 38 matching lines @@
   }
 }
 
 bool FormManager::FormWithNodeIsAutoFilled(const WebNode& node) {
   FormElement* form_element = NULL;
   if (!FindCachedFormElementWithNode(node, &form_element))
     return false;
 
   for (size_t i = 0; i < form_element->control_elements.size(); ++i) {
     WebFormControlElement element = form_element->control_elements[i];
-    if (element.formControlType() != WebString::fromUTF8("text"))
+    WebInputElement input_element = element.to<WebInputElement>();
+    if (!IsTextInput(input_element))
       continue;
 
-    const WebInputElement& input_element = element.to<WebInputElement>();
     if (input_element.isAutofilled())
       return true;
   }
 
   return false;
 }
 
 // static
 string16 FormManager::InferLabelForElement(
     const WebFormControlElement& element) {
@@ skipping 89 matching lines @@
     if (k >= data.fields.size())
       continue;
 
     DCHECK_EQ(data.fields[k].name(), element_name);
 
     bool is_initiating_node = false;
 
     // More than likely |requirements| will contain REQUIRE_AUTOCOMPLETE and/or
     // REQUIRE_EMPTY, which both require text form control elements, so special-
     // case this type of element.
-    if (element->formControlType() == WebString::fromUTF8("text")) {
-      const WebInputElement& input_element =
-          element->toConst<WebInputElement>();
+    const WebInputElement& input_element =
+        element->toConst<WebInputElement>();
+    if (IsTextInput(input_element)) {
 
       // TODO(jhawkins): WebKit currently doesn't handle the autocomplete
       // attribute for select control elements, but it probably should.
       if (requirements & REQUIRE_AUTOCOMPLETE && !input_element.autoComplete())
         continue;
 
       is_initiating_node = (input_element == node);
       // Don't require the node that initiated the auto-fill process to be
       // empty.  The user is typing in this field and we should complete the
       // value when the user selects a value to fill out.
@@ skipping 15 matching lines @@
   delete callback;
 }
 
 void FormManager::FillFormField(WebFormControlElement* field,
                                 const FormField* data,
                                 bool is_initiating_node) {
   // Nothing to fill.
   if (data->value().empty())
     return;
 
-  if (field->formControlType() == WebString::fromUTF8("text")) {
-    WebInputElement input_element = field->to<WebInputElement>();
+  WebInputElement input_element = field->to<WebInputElement>();
+  if (IsTextInput(input_element)) {
 
     // If the maxlength attribute contains a negative value, maxLength()
     // returns the default maxlength value.
     input_element.setValue(data->value().substr(0, input_element.maxLength()));
     input_element.setAutofilled(true);
     if (is_initiating_node) {
       int length = input_element.value().length();
       input_element.setSelectionRange(length, length);
     }
   } else if (field->formControlType() == WebString::fromUTF8("select-one")) {
     WebSelectElement select_element = field->to<WebSelectElement>();
     select_element.setValue(data->value());
   }
 }
 
 void FormManager::PreviewFormField(WebFormControlElement* field,
                                    const FormField* data,
                                    bool is_initiating_node) {
   // Nothing to preview.
   if (data->value().empty())
     return;
 
   // Only preview input fields.
-  if (field->formControlType() != WebString::fromUTF8("text"))
+  WebInputElement input_element = field->to<WebInputElement>();
+  if (!IsTextInput(input_element))
     return;
 
-  WebInputElement input_element = field->to<WebInputElement>();
-
   // If the maxlength attribute contains a negative value, maxLength()
   // returns the default maxlength value.
   input_element.setSuggestedValue(
       data->value().substr(0, input_element.maxLength()));
   input_element.setAutofilled(true);
   if (is_initiating_node)
     input_element.setSelectionRange(0, input_element.suggestedValue().length());
 }