Support autocompletion for HTMl5 tags:"email", "month" and "tel".

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <limits>
 #include <set>
 
 #include "app/l10n_util.h"
@@ skipping 670 matching lines @@
 
 void AutoFillManager::FillCreditCardFormField(const CreditCard* credit_card,
                                               AutoFillType type,
                                               webkit_glue::FormField* field) {
   DCHECK(credit_card);
   DCHECK(type.group() == AutoFillType::CREDIT_CARD);
   DCHECK(field);
 
   if (field->form_control_type() == ASCIIToUTF16("select-one"))
     autofill::FillSelectControl(credit_card, type, field);
+  else if (field->form_control_type() == ASCIIToUTF16("month"))
+    // THML5 input="month" consisnts of year-month.

[James Hawkins, 2011/01/03 19:50:00]

Spelling errors in this comment.

+    field->set_value(
+        credit_card->GetFieldText(AutoFillType(CREDIT_CARD_EXP_4_DIGIT_YEAR)) +

[James Hawkins, 2011/01/03 19:50:00]

Please extract a variable from these lines and send that to set_value.  Note
that the style guide says each continuation of one line must be indented four
spaces from the previous line.

Personally, I'd do:

string16 month = credit_card->GetFieldText(...);
month += ASCIIToUTF16("-");
month += credit_card->GetFieldText(...);

+        string16(ASCIIToUTF16("-")) +

[James Hawkins, 2011/01/03 19:50:00]

No need to wrap with string16().

+        credit_card->GetFieldText(AutoFillType(CREDIT_CARD_EXP_MONTH)));
   else
     field->set_value(credit_card->GetFieldText(type));
 }
 
 void AutoFillManager::FillFormField(const AutoFillProfile* profile,
                                     AutoFillType type,
                                     webkit_glue::FormField* field) {
   DCHECK(profile);
   DCHECK(type.group() != AutoFillType::CREDIT_CARD);
   DCHECK(field);
@@ skipping 109 matching lines @@
     return std::string();
 
   std::map<int, std::string>::const_iterator iter = id_guid_map_.find(id);
   if (iter == id_guid_map_.end()) {
     NOTREACHED();
     return std::string();
   }
 
   return iter->second;
 }