Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 6033008: Move compat_execinfo to the mac directory since this is mac-specific.... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove compat_execinfo since we no longer support Mac 10.4. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70288

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
D base/compat_execinfo.h View 1 chunk +0 lines, -34 lines 0 comments Download
M base/debug/debugger_posix.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
9 years, 11 months ago (2010-12-29 21:48:20 UTC) #1
viettrungluu
This seems wrong to me, since it's intended to be used on any POSIX platform. ...
9 years, 11 months ago (2010-12-29 22:03:55 UTC) #2
brettw
I like that solution, PTAL.
9 years, 11 months ago (2010-12-29 22:15:05 UTC) #3
Avi (use Gerrit)
http://codereview.chromium.org/6033008/diff/15001/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): http://codereview.chromium.org/6033008/diff/15001/base/debug/stack_trace_posix.cc#newcode33 base/debug/stack_trace_posix.cc:33: #include "base/mac/compat_execinfo.h" This file no longer exists.
9 years, 11 months ago (2010-12-29 22:17:51 UTC) #4
brettw
http://codereview.chromium.org/6033008/diff/15001/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): http://codereview.chromium.org/6033008/diff/15001/base/debug/stack_trace_posix.cc#newcode33 base/debug/stack_trace_posix.cc:33: #include "base/mac/compat_execinfo.h" Fixed.
9 years, 11 months ago (2010-12-29 22:20:37 UTC) #5
viettrungluu
LGTM assuming it builds.
9 years, 11 months ago (2010-12-29 22:31:44 UTC) #6
Avi (use Gerrit)
9 years, 11 months ago (2010-12-29 22:36:50 UTC) #7
LG

Powered by Google App Engine
This is Rietveld 408576698