Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 6033001: parallel_emerge now uninstalls packages correctly when use flags change. (Closed)

Created:
10 years ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

parallel_emerge now uninstalls packages correctly when use flags change. When I added the --force-remote-binary flag, I needed to find a way to get emerge to install binary packages whose use flags were not fully up to date. To do this, I removed the --newuse flag from the call to the emerge depgraph calculation code. This seemed safe at the time because parallel_emerge already checks the use flags of every package it installs. Unfortunately, things are a little more complex. Sometimes, emerge decides to install a different version of a package because of a use flag change. To implement this, Portage needs to know about the --newuse flag. To fix this bug, I've updated parallel_emerge to force in the remote binary packages using a less intrusive method, that only impacts the package that is being forced. This method should have less side effects and allow us to install packages correctly. TEST=./setup_board --board=tegra2_dev-board --force && ./parallel_emerge --board=tegra2_dev-board -uDNvg opengles && ./parallel_emerge --board=tegra2_dev-board -puDNvg board-devices ./parallel_emerge --board=tegra2_dev-board -uDNvg chromeos --force-remote-binary=chromeos-chrome BUG=chromium-os:10423 Change-Id: I2057d2992abcb08f184cfaa6c099bd6eb8c21a99 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fa98729

Patch Set 1 #

Patch Set 2 : Better indentation #

Patch Set 3 : More comments #

Patch Set 4 : Remove extra line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -48 lines) Patch
M parallel_emerge View 1 2 3 7 chunks +95 lines, -48 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years ago (2010-12-17 20:27:16 UTC) #1
Nick Sanders
10 years ago (2010-12-18 03:09:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698