Issue 6032006: Exclude some net_ tests and suppress a couple of stacks for Dr. Memory...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6032006: Exclude some net_ tests and suppress a couple of stacks for Dr. Memory... (Closed)

Created:
10 years ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Exclude some net_ tests and suppress a couple of stacks for Dr. Memory TBR=glider TEST=Dr.Memory FYI bot should go greener Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70157

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
	M	tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years ago (2010-12-24 13:30:05 UTC) #2

LGTM

On Fri, Dec 24, 2010 at 2:30 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Exclude some net_ tests and suppress a couple of stacks for Dr. Memory
> TBR=glider
> TEST=Dr.Memory FYI bot should go greener
>
> Please review this at http://codereview.chromium.org/6032006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/drmemory/suppressions.txt
>  M     tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
>
>
> Index: tools/valgrind/drmemory/suppressions.txt
> ===================================================================
> --- tools/valgrind/drmemory/suppressions.txt    (revision 70146)
> +++ tools/valgrind/drmemory/suppressions.txt    (working copy)
> @@ -1,4 +1,11 @@
>  ############################
> +# Known reports on the third party we have no control over.
> +UNINITIALIZED READ
> +...
> +*!deflate_slow
> +*!MOZ_Z_deflate
> +
> +############################
>  # Suppress some false reports due to bugs in Dr.Memory like wrong analysis
>  # assumptions or unhandled syscalls
>
> @@ -322,6 +329,10 @@
>  ntdll.dll!RtlAbsoluteToSelfRelativeSD
>  ADVAPI32.dll!MakeSelfRelativeSD
>
> +UNINITIALIZED READ
> +...
> +CRYPT32.dll!I_CertSyncStore
> +
>  ############################
>  # Intentional errors in Chromium tests (ToolsSanityTests)
>
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> (revision 70146)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt
> (working copy)
> @@ -4,8 +4,10 @@
>
>  # TODO(timurrrr): investigate these
>  ClientSocketPoolBaseTest.*
> +CookieMonsterTest.GarbageCollectionTriggers
>  SSLClientSocketTest.*
>  ProxyResolverJS*
> +ProxyResolverV8Test.*
>  X509CertificateTest.*
>  UrlToFilenameEncoderTest.*
>  DirectoryListerTest.*
>
>
>

Expand Messages | Collapse Messages