Fix UI-thread blocking issue in SetImeConfig

Fix UI-thread blocking issue in SetImeConfig.

Do not kill ibus-daemon before FlushImeConfig() since it can lead the ibus_config_set_value() call to block for 25 seconds (i.e. GDBus default timeout) when ibus-1.4 and GDBus libraries are in use.

BUG=chromium-os:9685
TEST=manually with ibus-1.3 and 1.4.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70598

[satorux1, 2011-01-05 06:52:31]

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/input_method_library.cc (right):

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:169: section, config_name,
value, false /* auto_ime_shutdown */);
This is a bit hard to read. I think it would be easier to read if we have two
separate functions:

MaybeStartInputMethodProcesses(section, config_name, value);
MaybeStopInputMethodProcesses(section, config_name, value);

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:196: // Starts or stops the
input method processes based on the current state.
Please add comments about parameters using this opportunity.

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:202: if
(!strcmp(language_prefs::kGeneralSectionName, section) &&
You might want to change the parameters to const string& so you can use ==. If
you do, you probably want to change SetImeConfig() and GetImeConfig(). Other
functions seem to use const string& rather than const char*.

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:600: bool
enable_auto_ime_shutdown_;
Could you write a comment about this?

[Yusuke Sato, 2011-01-05 10:05:54]

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/input_method_library.cc (right):

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:169: section, config_name,
value, false /* auto_ime_shutdown */);
On 2011/01/05 06:52:31, satorux1 wrote:
> This is a bit hard to read. I think it would be easier to read if we have two
> separate functions:
> 
> MaybeStartInputMethodProcesses(section, config_name, value);
> MaybeStopInputMethodProcesses(section, config_name, value);
> 

Done.

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:196: // Starts or stops the
input method processes based on the current state.
On 2011/01/05 06:52:31, satorux1 wrote:
> Please add comments about parameters using this opportunity.

Done.

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:202: if
(!strcmp(language_prefs::kGeneralSectionName, section) &&
On 2011/01/05 06:52:31, satorux1 wrote:
> You might want to change the parameters to const string& so you can use ==. If
> you do, you probably want to change SetImeConfig() and GetImeConfig(). Other
> functions seem to use const string& rather than const char*.

Done.

http://codereview.chromium.org/6032005/diff/8001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/input_method_library.cc:600: bool
enable_auto_ime_shutdown_;
On 2011/01/05 06:52:31, satorux1 wrote:
> Could you write a comment about this?

Done.

[satorux1, 2011-01-06 04:37:47]

LGTM