Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 6031003: Add support for an alternate svn config directory for both svn and git-svn. (Closed)

Created:
10 years ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)
Visibility:
Public.

Description

Add support for an alternate svn config directory for both svn and git-svn. Add subversion_config directory. Otherwise the commit queue messes the user's cached svn credentials. This also fixes git svn authentication. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70086

Patch Set 1 #

Patch Set 2 : Rebase against trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M checkout.py View 1 11 chunks +33 lines, -22 lines 0 comments Download
A subversion_config/config View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Dependent on http://codereview.chromium.org/6020010/ This one is quite important since it fixes all the credential cache ...
10 years ago (2010-12-22 18:17:16 UTC) #1
Dirk Pranke
The code looks basically fine, but there are references to an "auth" file and a ...
10 years ago (2010-12-22 23:22:29 UTC) #2
M-A Ruel
On 2010/12/22 23:22:29, dpranke wrote: > The code looks basically fine, but there are references ...
10 years ago (2010-12-23 04:07:36 UTC) #3
M-A Ruel
10 years ago (2010-12-23 17:32:09 UTC) #4
I'll commit the patch since I use these pending patches to iron out the
remaining issues but feel free to ask me for any follow up changes.

Powered by Google App Engine
This is Rietveld 408576698