Issue 603056: Create debian.chrome config for qualcomm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603056: Create debian.chrome config for qualcomm. (Closed)

Created:
10 years, 10 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
robotboy, tgardner

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Create debian.chrome config for qualcomm.

Patch Set 1 #

Total comments: 8

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1066 lines, -293 lines)			Patch
A	debian.chrome/config/armel/config.common.armel	View	1 chunk	+309 lines, -0 lines	0 comments	Download
A	debian.chrome/config/armel/config.flavour.qsd8650-st1	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	debian.chrome/config/config.common.chromeos	View	88 chunks	+457 lines, -293 lines	8 comments	Download
M	debian.chrome/config/i386/config.common.i386	View	1 chunk	+297 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robotboy

10 years, 10 months ago (2010-02-13 21:20:03 UTC) #2

I stopped going through the files once I saw that they were auto-generated. 
There are a huge number of options set in places that I think are incorrect. 
Like ARM specific things in the common config.  Android configs in i386...  Are
these expected?  Is the plan to clean all of this up after the move to a split
kernel config?

http://codereview.chromium.org/603056/diff/1/4
File debian.chrome/config/config.common.chromeos (right):

http://codereview.chromium.org/603056/diff/1/4#newcode69
debian.chrome/config/config.common.chromeos:69: CONFIG_ANDROID_PMEM=y
Do we want Android specific stuff in our kernel?

http://codereview.chromium.org/603056/diff/1/4#newcode71
debian.chrome/config/config.common.chromeos:71: CONFIG_ANDROID_PMEM_KAPI_TEST=m
Especially in the common config?

http://codereview.chromium.org/603056/diff/1/4#newcode112
debian.chrome/config/config.common.chromeos:112: CONFIG_ARCH_MSM=y
This is Qualcomm specific yes, shouldn't it go in the qsd8x50 flavor?

http://codereview.chromium.org/603056/diff/1/4#newcode117
debian.chrome/config/config.common.chromeos:117: CONFIG_ARCH_MSM_SCORPION=y
Same here.

http://codereview.chromium.org/603056/diff/1/4#newcode128
debian.chrome/config/config.common.chromeos:128: CONFIG_ARCH_QSD8X50=y
And here.

http://codereview.chromium.org/603056/diff/1/4#newcode147
debian.chrome/config/config.common.chromeos:147: CONFIG_ARM=y
And these should be in the arm common right?

http://codereview.chromium.org/603056/diff/1/4#newcode223
debian.chrome/config/config.common.chromeos:223: CONFIG_BATTERY_MSM=m
Qualcomm specific.

http://codereview.chromium.org/603056/diff/1/4#newcode622
debian.chrome/config/config.common.chromeos:622: CONFIG_FB_MSM=y
All of these are Qualcomm specific.

Expand Messages | Collapse Messages