Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 603028: Compile very thin code to access objects on which indexed interceptor is set. (Closed)

Created:
10 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Compile very thin code to access objects on which indexed interceptor is set. Committed: http://code.google.com/p/v8/source/detail?r=3847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -0 lines) Patch
M src/arm/ic-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M src/ic.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +189 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, may you have a look? Couple of comments: 1) I'll do obvious ports to ...
10 years, 10 months ago (2010-02-11 09:49:11 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-12 10:57:42 UTC) #2
LGTM

We use MEGAMORPHIC for all the keyed load stubs because they all work for many
forms of objects (nothing map specific).  We have no MONOMORPHIC keyed load
stubs. 

On 2010/02/11 09:49:11, antonm wrote:
> Mads, may you have a look?
> 
> Couple of comments:
> 
> 1) I'll do obvious ports to other archs after first review path;
> 
> 2) I don't quite understand what MEGAMORPHIC kind means when describing stub
> generators in builtins.h as for element loading we don't go megamorphic AFAIK,
> if you can educate me here, that'd be cool.  My current hypothesis is 'we
might
> need it later'

Powered by Google App Engine
This is Rietveld 408576698