Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 6029007: Heapcheck: suppress bug 68290 (leaks in URLRequest::ResponseStarted)... (Closed)

Created:
9 years, 11 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Heapcheck: suppress bug 68290 (leaks in URLRequest::ResponseStarted) and bug 68304 (leaks in ResourceDispatcherHostTest.*) TBR=jam BUG=68290, 68304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
9 years, 11 months ago (2010-12-30 14:53:01 UTC) #1
jam
9 years, 11 months ago (2011-01-04 21:26:41 UTC) #2
lgtm

On Thu, Dec 30, 2010 at 6:53 AM, <glider@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Message:
> TBR
>
> Description:
> Heapcheck: suppress bug 68290 (leaks in URLRequest::ResponseStarted)
> and bug 68304 (leaks in ResourceDispatcherHostTest.*)
>
> TBR=jam
> BUG=68290,68304
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70311
>
> Please review this at http://codereview.chromium.org/6029007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/heapcheck/suppressions.txt
>
>
> Index: tools/heapcheck/suppressions.txt
> ===================================================================
> --- tools/heapcheck/suppressions.txt    (revision 70310)
> +++ tools/heapcheck/suppressions.txt    (working copy)
> @@ -1174,3 +1174,36 @@
>
> 
fun:_ZN3net22HttpNetworkTransaction5StartEPKNS_15HttpRequestInfoEP14CallbackRunnerI6Tuple1IiEERKNS_11BoundNetLogE
>    fun:_ZN3net9HttpCache11Transaction13DoSendRequestEv
>  }
> +# URLRequest*Job stands for
> {URLRequestJob,URLRequestChromeJob,URLRequestHttpJob}
> +{
> +   bug_68290
> +   Heapcheck:Leak
> +   fun:ResourceDispatcherHost::NotifyResponseStarted
> +   fun:ResourceDispatcherHost::CompleteResponseStarted
> +   fun:ResourceDispatcherHost::OnResponseStarted
> +   fun:net::URLRequest::ResponseStarted
> +   fun:net::URLRequest*Job::NotifyHeadersComplete
> +   fun:URLRequestTestJob::StartAsync
> +   fun:void DispatchToMethod
> +   fun:RunnableMethod::Run
> +   fun:MessageLoop::RunTask
> +   fun:MessageLoop::DeferOrRunPendingTask
> +   fun:MessageLoop::DoWork
> +}
> +{
> +   bug_68304
> +   Heapcheck:Leak
> +   fun:__gnu_cxx::new_allocator::allocate
> +   fun:std::string::_Rep::_S_create
> +   fun:std::string::_M_mutate
> +   fun:std::string::_M_replace_safe
> +   fun:std::string::assign
> +   fun:Pickle::ReadString
> +   ...
> +   fun:IPC::ParamTraits::Read
> +   fun:IPC::ReadParam
> +   fun:IPC::MessageWithTuple::Read
> +   fun:IPC::MessageWithTuple::Dispatch
> +   fun:ResourceDispatcherHost::OnMessageReceived
> +   fun:ResourceDispatcherHostTest::MakeTestRequest
> +}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698