Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 6029004: Split FakeRepos class in two so it can be reused for commti-queue unit tests. (Closed)

Created:
10 years ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Split FakeRepos class in two so it can be reused for commti-queue unit tests. FakeRepos is useful for offline SCM tests but it was hardcoded for depot_tools requirements. Luckily, it was already modular enought that it merely required to shuffle code around to split it in two classes to be able to reuse the code as-is. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M tests/fake_repos.py View 6 chunks +55 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years ago (2010-12-20 16:42:09 UTC) #1
Dirk Pranke
10 years ago (2010-12-21 01:47:31 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698