Issue 6028015: Make the popup blocker on by default. Flip the flag to be a disabling one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6028015: Make the popup blocker on by default. Flip the flag to be a disabling one. (Closed)

Created:
9 years, 11 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY, Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make the popup blocker on by default. Flip the flag to be a disabling one. BUG=60090 TEST=On Windows and Mac, when a popup is blocked, there's an animation in the Omnibox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70775

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

On 2011/01/07 19:19:01, Nico wrote:
> LG

LGTM