Issue 6027007: Printing: Get settings on the UI thread on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6027007: Printing: Get settings on the UI thread on all platforms. (Closed)

Created:
10 years ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, M-A Ruel

CC:
chromium-reviews, sanjeevr

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Printing: Get settings on the UI thread on all platforms. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70591

Patch Set 1 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -19 lines)			Patch
	M	chrome/browser/printing/print_job_worker.h	View		3 chunks	+3 lines, -4 lines	0 comments	Download
	M	chrome/browser/printing/print_job_worker.cc	View		4 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

9 years, 11 months ago (2011-01-06 04:12:19 UTC) #4

On 2010/12/23 03:18:27, Marc-Antoine Ruel wrote:
> lgtm, will probably fix http://crbug.com/2142.

It did! As soon as a continuous build finishes, I'll ask users to try it out to
verify.

Expand Messages | Collapse Messages