Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 6027006: Move git config till after we sync. (Closed)

Created:
10 years ago by sosa
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Move git config till after we sync. This deals with the condition where on a clobber we don't actually re-config to use ssh:// until the second run (because git config is called before we first sync the code). Change-Id: Icf1a46aced633b570db9d280b10ae6866af04709 BUG=chromium-os:10545 TEST=Unit tests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b1d17e2

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bin/cbuildbot.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
10 years ago (2010-12-22 21:27:08 UTC) #1
Mandeep Singh Baines
10 years ago (2010-12-22 22:08:29 UTC) #2
LGTM. Thanks!

sosa@chromium.org (sosa@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines,
> 
> Description:
> Move git config till after we sync.
> 
> This deals with the condition where on a clobber we don't actually
> re-config to use ssh:// until the second run (because git config is
> called before we first sync the code).
> 
> Change-Id: Icf1a46aced633b570db9d280b10ae6866af04709
> 
> BUG=chromium-os:10545
> TEST=Unit tests
> 
> Please review this at http://codereview.chromium.org/6027006/
> 
> SVN Base: http://git.chromium.org/git/crosutils.git@master
> 
> Affected files:
>   M bin/cbuildbot.py
> 
> 
> Index: bin/cbuildbot.py
> diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
> index
90e965bb4f496c18aa4dd3f1d3cddec851bfe62a..ff3fb8a94c878e42fecd17bc15e008d472842a98
> 100755
> --- a/bin/cbuildbot.py
> +++ b/bin/cbuildbot.py
> @@ -74,10 +74,10 @@ def RepoSync(buildroot, retries=_DEFAULT_RETRIES):
>        # The --trace option ensures that repo shows the output from
> git. This
>        # is needed so that the buildbot can kill us if git is not making
>        # progress.
> +      RunCommand(['repo', '--trace', 'sync'], cwd=buildroot)
>        RunCommand(['repo', 'forall', '-c', 'git', 'config',
>                    'url.ssh://git@gitrw.chromium.org:9222.insteadof',
>                    'http://git.chromium.org/git'], cwd=buildroot)
> -      RunCommand(['repo', '--trace', 'sync'], cwd=buildroot)
>        retries = 0
>      except:
>        retries -= 1
> 
> 

Powered by Google App Engine
This is Rietveld 408576698