Add flashmap (fmap) support to Flashrom

layout.c

 /*
  * This file is part of the flashrom project.
  *
  * Copyright (C) 2005-2008 coresystems GmbH
  * (Written by Stefan Reinauer <stepan@coresystems.de> for coresystems GmbH)
+ * Portions (C) 2010 Google Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; version 2 of the License.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <ctype.h>
 #include <limits.h>
 #include "flash.h"
+#include "fmap.h"
 #include "programmer.h"
 
 #if CONFIG_INTERNAL == 1
 char *mainboard_vendor = NULL;
 char *mainboard_part = NULL;
 #endif
 static int romimages = 0;
 
 #define MAX_ROMLAYOUT   64
 
@@ skipping 157 matching lines @@
                              rom_entries[i].start,
                              rom_entries[i].end, rom_entries[i].name);
         }
 
         fclose(romlayout);
 
         return 0;
 }
 #endif
 
+/* returns the number of entries added, or <0 to indicate error */
+int add_fmap_entries(struct flashchip *flash)
+{
+        int i, fmap_size;
+        uint8_t *buf;
+        struct fmap *fmap;
+
+        fmap_size = fmap_find(flash, &buf);
+        if (fmap_size == 0) {
+                msg_gdbg("%s: no fmap present\n", __func__);
+                return 0;
+        } else if (fmap_size < 0) {
+                msg_gdbg("%s: error reading fmap\n", __func__);
+                return -1;
+        } else {
+                msg_gdbg("%s: fmap_size: %d\n", __func__, fmap_size);
+                fmap = (struct fmap *)(buf);
+        }
+
+        for (i = 0; i < fmap->nareas; i++) {
+                if (romimages >= MAX_ROMLAYOUT) {
+                        msg_gerr("ROM image contains too many regions\n");
+                        return -1;
+                }
+                rom_entries[romimages].start = fmap->areas[i].offset;
+
+                /*
+                 * Flashrom rom entries use absolute addresses. So for non-zero
+                 * length entries, we need to subtract 1 from offset + size to
+                 * determine the end address.
+                 */
+                rom_entries[romimages].end = fmap->areas[i].offset +
+                                             fmap->areas[i].size;
+                if (fmap->areas[i].size)
+                        rom_entries[romimages].end--;
+
+                memset(rom_entries[romimages].name, 0,
+                       sizeof(rom_entries[romimages].name));
+                memcpy(rom_entries[romimages].name, fmap->areas[i].name,
+                       min(sizeof(rom_entries[romimages].name),
+                           sizeof(fmap->areas[i].name)));
+
+                rom_entries[romimages].included = 0;
+                strcpy(rom_entries[romimages].file, "");
+
+                msg_gdbg("added fmap region \"%s\" (file=\"%s\") as %sincluded,"
+                         " offset: 0x%08x, size: 0x%08x\n",
+                          rom_entries[romimages].name,
+                          rom_entries[romimages].file,
+                          rom_entries[romimages].included ? "" : "not ",
+                          rom_entries[romimages].start,
+                          rom_entries[romimages].end);
+                romimages++;
+        }
+

[Louis, 2011/03/05 01:05:01]

buf must be freed.

[dhendrix, 2011/03/05 02:34:14]

d'oh! good catch. I also added free(buf) before line 228 (in case of error).

+        return fmap->nareas;
+}
+
 /* register an include argument (-i) for later processing */
 int register_include_arg(char *name)
 {
         static int i = 0;
 
         if (i >= MAX_ROMLAYOUT) {
                 msg_gerr("too many regions included\n");
                 return -1;
         }
 
@@ skipping 213 matching lines @@
 
                 /* Skip to location after current romentry. */
                 start = rom_entries[entry].end + 1;
                 /* Catch overflow. */
                 if (!start)
                         break;
         }
 
         return count;
 }