Issue 6025010: [binutils] Fix tls transition check from R_X86_64_GOTTPOFF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6025010: [binutils] Fix tls transition check from R_X86_64_GOTTPOFF (Closed)

Created:
9 years, 12 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git@master

Visibility:
Public.

Description

[binutils] Fix tls transition check from R_X86_64_GOTTPOFF x86_64 linker expects either movq or addq there, while for NaCl we generate movl or addl. Fixed the check to accept movl and addl, the rewrite itself seems to work as is. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1278 TEST= Committed: http://git.chromium.org/gitweb/?p=nacl-toolchain.git;a=commit;h=471f6c4

Patch Set 1 #

Patch Set 2 : ready for code review #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	binutils/bfd/elf64-x86-64.c	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages