chrome/browser/safe_browsing/safe_browsing_service.h - Issue 6025005: Consolidate some safe-browsing histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 6025005: Consolidate some safe-browsing histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Histogram hits instead of misses, also empty responses. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_service.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h

index abade47a6df31f129df2e48b7f7e6c4a0f329e24..5ea5f831a794a9104e0817cbcd416dd99c1d71b0 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.h

+++ b/chrome/browser/safe_browsing/safe_browsing_service.h

@@ -307,7 +307,9 @@ class SafeBrowsingService

void OnHandleGetHashResults(SafeBrowsingCheck* check,

const std::vector<SBFullHashResult>& full_hashes);

- void HandleOneCheck(SafeBrowsingCheck* check,

+ // Run one check against |full_hashes|. Returns |true| if the check

+ // finds a match in |full_hashes|.

+ bool HandleOneCheck(SafeBrowsingCheck* check,

const std::vector<SBFullHashResult>& full_hashes);

// Invoked on the UI thread to show the blocking page.