Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_gtk.cc

Issue 6024008: Consider the popup window position when the window shows upward. This patch depends on WebKit patch. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Chnage the order of SetSize() and SetBounds() in Gtk. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_gtk.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
index 5ef533dea8fd6912004f05859bb5833fc9e791e3..97dd8d3041bf7ad43718440044a3beefb451d5e8 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_gtk.cc
@@ -602,7 +602,6 @@ void RenderWidgetHostViewGtk::WasHidden() {
}
void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
- // This is called when webkit has sent us a Move message.
int width = std::min(size.width(), kMaxWindowWidth);
int height = std::min(size.height(), kMaxWindowHeight);
if (IsPopup()) {
@@ -616,6 +615,7 @@ void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
gtk_widget_set_size_request(view_.get(), width, height);
#endif
}
+
// Update the size of the RWH.
if (requested_size_.width() != width ||
requested_size_.height() != height) {
@@ -624,6 +624,15 @@ void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
}
}
+void RenderWidgetHostViewGtk::SetBounds(const gfx::Rect& rect) {
+ // This is called when webkit has sent us a Move message.
+ GtkWidget* parent_widget = gtk_widget_get_parent(view_.get());
+ if (GTK_IS_WINDOW(parent_widget))
Evan Stade 2011/02/23 20:25:18 can you use IsPopup() and then do gtk_widget_get_t
honten.org 2011/02/24 08:03:58 Done.
+ gtk_window_move(GTK_WINDOW(parent_widget), rect.x(), rect.y());
+
+ SetSize(rect.size());
+}
+
gfx::NativeView RenderWidgetHostViewGtk::GetNativeView() {
return view_.get();
}

Powered by Google App Engine
This is Rietveld 408576698