chrome/browser/renderer_host/render_widget_host.cc - Issue 6024008: Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host.cc

Issue 6024008: Consider the popup window position when the window shows upward. This patch depends on WebKit patch. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Use SetBounds(). Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/render_widget_host.cc

diff --git a/chrome/browser/renderer_host/render_widget_host.cc b/chrome/browser/renderer_host/render_widget_host.cc

index 13e5da7a8eb39e0b41caca0f754b8bba7de7a4d8..cda35dc3bfc6f7dd012eac74c11f1969f99b4797 100644

--- a/chrome/browser/renderer_host/render_widget_host.cc

+++ b/chrome/browser/renderer_host/render_widget_host.cc

@@ -800,7 +800,7 @@ void RenderWidgetHost::OnMsgClose() {

void RenderWidgetHost::OnMsgRequestMove(const gfx::Rect& pos) {

// Note that we ignore the position.

if (view_) {

- view_->SetSize(pos.size());

+ view_->SetBounds(pos);

Send(new ViewMsg_Move_ACK(routing_id_));

}

« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view.h » ('j') | chrome/browser/renderer_host/render_widget_host_view.h » ('J')