Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: content/browser/renderer_host/render_widget_host.cc

Issue 6024008: Consider the popup window position when the window shows upward. This patch depends on WebKit patch. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix format errors. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host.cc
diff --git a/content/browser/renderer_host/render_widget_host.cc b/content/browser/renderer_host/render_widget_host.cc
index 076d3e04d56832242ce39a07c9c4ad44c288a04e..5ddd7e5b1bb370f6dab317b30710853c70da68e6 100644
--- a/content/browser/renderer_host/render_widget_host.cc
+++ b/content/browser/renderer_host/render_widget_host.cc
@@ -800,7 +800,7 @@ void RenderWidgetHost::OnMsgClose() {
void RenderWidgetHost::OnMsgRequestMove(const gfx::Rect& pos) {
// Note that we ignore the position.
Peter Kasting 2011/03/07 19:25:44 This comment lies. Is the change below desirable?
honten.org 2011/03/07 19:36:07 You are right. We should should remove it. On 20
Peter Kasting 2011/03/07 20:20:15 I'm just really curious. "Request move" sounds li
honten.org 2011/03/07 21:19:50 I don't know why. AFAIK, |pos| originally doesn't
if (view_) {
- view_->SetSize(pos.size());
+ view_->SetBounds(pos);
Send(new ViewMsg_Move_ACK(routing_id_));
}
}

Powered by Google App Engine
This is Rietveld 408576698