Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_gtk.h"
 
 // If this gets included after the gtk headers, then a bunch of compiler
 // errors happen because of a "#define Status int" in Xlib.h, which interacts
 // badly with net::URLRequestStatus::Status.
 #include "chrome/common/render_messages.h"
@@ skipping 584 matching lines @@
   // ignore them so we don't re-allocate the backing store.  We will paint
   // everything again when we become selected again.
   is_hidden_ = true;
 
   // If we have a renderer, then inform it that we are being hidden so it can
   // reduce its resource utilization.
   GetRenderWidgetHost()->WasHidden();
 }
 
 void RenderWidgetHostViewGtk::SetSize(const gfx::Size& size) {
+  gfx::Rect rect = GetViewBounds();
+  rect.set_size(size);
+  SetBounds(rect);

[Evan Stade, 2011/02/22 19:56:19]

this is backwards. SetBounds should use SetSize, not the reverse.

[honten.org, 2011/02/23 01:31:57]

Done.

+}
+
+void RenderWidgetHostViewGtk::SetBounds(const gfx::Rect& rect) {
   // This is called when webkit has sent us a Move message.
-  int width = std::min(size.width(), kMaxWindowWidth);
-  int height = std::min(size.height(), kMaxWindowHeight);
+  int width = std::min(rect.width(), kMaxWindowWidth);
+  int height = std::min(rect.height(), kMaxWindowHeight);
   if (IsPopup()) {
     // We're a popup, honor the size request.
     gtk_widget_set_size_request(view_.get(), width, height);
   } else {
 #if defined(TOOLKIT_VIEWS)
     // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and
     // size the widget.  In GTK+, the size of the widget is determined by its
     // children.
     gtk_widget_set_size_request(view_.get(), width, height);
 #endif
   }
+
+  GtkWidget* parent_widget = gtk_widget_get_parent(view_.get());
+  if (GTK_IS_WINDOW(parent_widget))
+    gtk_window_move(GTK_WINDOW(parent_widget), rect.x(), rect.y());
+
   // Update the size of the RWH.
   if (requested_size_.width() != width ||
       requested_size_.height() != height) {
     requested_size_ = gfx::Size(width, height);
     host_->WasResized();
   }
 }
 
 gfx::NativeView RenderWidgetHostViewGtk::GetNativeView() {
   return view_.get();
@@ skipping 27 matching lines @@
 void RenderWidgetHostViewGtk::Hide() {
   gtk_widget_hide(view_.get());
 }
 
 bool RenderWidgetHostViewGtk::IsShowing() {
   // TODO(jcivelli): use gtk_widget_get_visible once we build with GTK 2.18.
   return (GTK_WIDGET_FLAGS(view_.get()) & GTK_VISIBLE) != 0;
 }
 
 gfx::Rect RenderWidgetHostViewGtk::GetViewBounds() const {
-  GtkAllocation* alloc = &view_.get()->allocation;
-  return gfx::Rect(alloc->x, alloc->y,
+  gint x, y;
+  gtk_widget_get_pointer(view_.get(), &x, &y);

[Evan Stade, 2011/02/22 19:56:19]

I fail to see how the location of the pointer is relevant to anything

[honten.org, 2011/02/23 01:31:57]

Roll back.
On 2011/02/22 19:56:19, Evan Stade wrote:

+  return gfx::Rect(x, y,
                    requested_size_.width(),
                    requested_size_.height());
 }
 
 void RenderWidgetHostViewGtk::UpdateCursor(const WebCursor& cursor) {
   // Optimize the common case, where the cursor hasn't changed.
   // However, we can switch between different pixmaps, so only on the
   // non-pixmap branch.
   if (current_cursor_.GetCursorType() != GDK_CURSOR_IS_PIXMAP &&
       current_cursor_.GetCursorType() == cursor.GetCursorType()) {
@@ skipping 455 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView widget) {
   gpointer user_data = g_object_get_data(G_OBJECT(widget),
                                          kRenderWidgetHostViewKey);
   return reinterpret_cast<RenderWidgetHostView*>(user_data);
 }