Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_win.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
@@ skipping 348 matching lines @@
   // reduce its resource utilization.
   render_widget_host_->WasHidden();
 
   // TODO(darin): what about constrained windows?  it doesn't look like they
   // see a message when their parent is hidden.  maybe there is something more
   // generic we can do at the TabContents API level instead of relying on
   // Windows messages.
 }
 
 void RenderWidgetHostViewWin::SetSize(const gfx::Size& size) {
+  SetBounds(gfx::Rect(GetViewBounds.origin(), size));
+}
+
+void RenderWidgetHostViewWin::SetBounds(const gfx::Rect& rect) {
   if (is_hidden_)
     return;
 
-  // No SWP_NOREDRAW as autofill popups can resize and the underneath window
+  // No SWP_NOREDRAW as autofill popups can move and the underneath window
   // should redraw in that case.
   UINT swp_flags = SWP_NOSENDCHANGING | SWP_NOOWNERZORDER | SWP_NOCOPYBITS |
-      SWP_NOMOVE | SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE;
-  SetWindowPos(NULL, 0, 0, size.width(), size.height(), swp_flags);
+      SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE;
+
+  // If the style is not popup, you have to convert the point to client

[Peter Kasting, 2011/03/07 19:25:44]

The MSDN docs for SetWindowPos() say that the supplied X and Y are always
supposed to be in client coordinates.  There shouldn't be anything specific to
WS_POPUP.

[honten.org, 2011/03/07 19:36:07]

Yes, I thought so first. But it caused the problem.

Interestingly, ScreenToClient() for WS_POPUP convert positions to (0,0) even if
|rect| screen position is correct.

So I guess WS_POPUP should be special here.

What do you think?

On 2011/03/07 19:25:44, Peter Kasting wrote:

[Peter Kasting, 2011/03/07 20:20:15]

That sounds like a bug in ScreenToClient(), maybe.

Special-casing WS_POPUP _anywhere_ seems wrong.  The issue ought to be whether a
window is a child of another window, not what style it has.

You should ask Ben about this stuff, he understands it more than I do.

[honten.org, 2011/03/07 21:19:50]

Ok, I ask Ben.

On 2011/03/07 20:20:15, Peter Kasting wrote:

[Ben Goodger (Google), 2011/03/09 02:30:32]

Peter is right, this should check for !GetParent(GetNativeView()) instead.

If a window is not WS_CHILD, its position will be in screen coords. Otherwise it
will be in client coords.

[honten.org, 2011/03/09 02:33:03]

I see.

So, for now, if WS_POPUP is specified, WS_CHILD is not set. That is the reason
why ScreenToClient() returns (0,0).

Ok, I'll change it.

Thanks!!

On 2011/03/09 02:30:32, Ben Goodger wrote:

[honten.org, 2011/03/10 05:55:48]

Ben,

Unfortunately, this is not right. Even if I check GetParent(GetNativeView()), it
fails. I guess even if the window is not WS_CHILD, GetParent(GetNativeView())
returns the parent window, doesn't it?

Because GetParent(GetNativeView()) return the parent window specified when
calling Create(). As you know, in RenderWidgetHostViewWin::InitAsPopup(), we
specify the parent window.
  
So we should check WS_CHILD instead of parent window, right? Actually I made
sure WS_CHILD checkin works fine.

On 2011/03/09 02:33:03, honten wrote:

+  // coordinate.
+  CPoint point(rect.x(), rect.y());
+  if (!(GetStyle() & WS_POPUP))
+    ScreenToClient(&point);
+
+  SetWindowPos(NULL, point.x, point.y, rect.width(), rect.height(), swp_flags);
   if (compositor_host_window_) {
-    ::SetWindowPos(compositor_host_window_,
-        NULL,
-        0, 0,
-        size.width(), size.height(),
+    ::SetWindowPos(compositor_host_window_, NULL, point.x, point.y,
+        rect.width(), rect.height(),
         SWP_NOSENDCHANGING | SWP_NOCOPYBITS | SWP_NOZORDER | SWP_NOACTIVATE);
   }
   render_widget_host_->WasResized();
   EnsureTooltip();
 }
 
 gfx::NativeView RenderWidgetHostViewWin::GetNativeView() {
   return m_hWnd;
 }
 
@@ skipping 1428 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView native_view) {
   return ::IsWindow(native_view) ?
       reinterpret_cast<RenderWidgetHostView*>(
           ViewProp::GetValue(native_view, kRenderWidgetHostViewKey)) : NULL;
 }