Consider the popup window position when the window shows upward. This patch depends on WebKit patch.

chrome/browser/renderer_host/render_widget_host_view_gtk.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_gtk.h"
 
 // If this gets included after the gtk headers, then a bunch of compiler
 // errors happen because of a "#define Status int" in Xlib.h, which interacts
 // badly with URLRequestStatus::Status.
 #include "chrome/common/render_messages.h"
@@ skipping 549 matching lines @@
 #endif
   }
   // Update the size of the RWH.
   if (requested_size_.width() != width ||
       requested_size_.height() != height) {
     requested_size_ = gfx::Size(width, height);
     host_->WasResized();
   }
 }
 
+void RenderWidgetHostViewGtk::SetMove(const gfx::Point& origin) {
+  // This is called when webkit has sent us a Move message.
+  if (IsPopup()) {
+    // We're a popup, honor the size request.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+        origin.x(), origin.y());

[Ilya Sherman, 2010/12/22 01:16:35]

nit: This should be indented to line up with "GTK" above (also in the chunk
below).

[honten.org, 2010/12/22 01:29:41]

Sorry, I cannot understand what you mean.
But I understand this part is not good.

On 2010/12/22 01:16:35, Ilya Sherman wrote:

[Ilya Sherman, 2010/12/22 01:39:58]

This should be formatted like so:

gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
                origin.x(), origin.y());

[honten.org, 2010/12/22 01:41:27]

Got it,

On 2010/12/22 01:39:58, Ilya Sherman wrote:

+  } else {
+#if defined(TOOLKIT_VIEWS)
+    // TOOLKIT_VIEWS' resize logic flow matches windows. so we go ahead and
+    // size the widget.  In GTK+, the size of the widget is determined by its
+    // children.
+    gtk_window_move(GTK_WINDOW(gtk_widget_get_parent(view_.get())),
+        origin.x(), origin.y());
+#endif
+  }
+}
+
 gfx::NativeView RenderWidgetHostViewGtk::GetNativeView() {
   return view_.get();
 }
 
 void RenderWidgetHostViewGtk::MovePluginWindows(
     const std::vector<webkit_glue::WebPluginGeometry>& moves) {
   for (size_t i = 0; i < moves.size(); ++i) {
     plugin_container_manager_.MovePluginContainer(moves[i]);
   }
 }
@@ skipping 487 matching lines @@
 }
 
 // static
 RenderWidgetHostView*
     RenderWidgetHostView::GetRenderWidgetHostViewFromNativeView(
         gfx::NativeView widget) {
   gpointer user_data = g_object_get_data(G_OBJECT(widget),
                                          kRenderWidgetHostViewKey);
   return reinterpret_cast<RenderWidgetHostView*>(user_data);
 }