Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: chrome/browser/ui/views/tab_contents/tab_contents_container.cc

Issue 6024007: First cut at creating a refactored version of tab_contents_views. This is (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with current head Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/tab_contents_container.cc
diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
index 90af9978f0e2e427713fe8107c12b04e0a562584..caa6fdcdadf3695bcbbe1186ac12a1f007dd47dc 100644
--- a/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
+++ b/chrome/browser/ui/views/tab_contents/tab_contents_container.cc
@@ -13,69 +13,15 @@
#include "chrome/common/notification_details.h"
#include "chrome/common/notification_source.h"
-#if defined(TOUCH_UI)
-#include "chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.h"
-#include "chrome/browser/ui/views/tab_contents/tab_contents_view_views.h"
-#include "views/border.h"
-#include "views/fill_layout.h"
-#endif
////////////////////////////////////////////////////////////////////////////////
// TabContentsContainer, public:
-TabContentsContainer::TabContentsContainer()
- : native_container_(NULL),
- tab_contents_(NULL) {
- SetID(VIEW_ID_TAB_CONTAINER);
-}
-
TabContentsContainer::~TabContentsContainer() {
if (tab_contents_)
RemoveObservers();
}
-void TabContentsContainer::ChangeTabContents(TabContents* contents) {
- if (tab_contents_) {
-#if !defined(TOUCH_UI)
- native_container_->DetachContents(tab_contents_);
-#else
- views::View *v = static_cast<TabContentsViewViews*>(tab_contents_->view());
- RemoveChildView(v);
-#endif
- tab_contents_->WasHidden();
- RemoveObservers();
- }
- tab_contents_ = contents;
- // When detaching the last tab of the browser ChangeTabContents is invoked
- // with NULL. Don't attempt to do anything in that case.
- if (tab_contents_) {
-#if defined(TOUCH_UI)
- views::View *v = static_cast<TabContentsViewViews*>(contents->view());
- // Guard against re-adding ourselves, which happens because the NULL
- // value is ignored by the pre-existing if() above.
- if (v->GetParent() != this) {
- AddChildView(v);
- SetLayoutManager(new views::FillLayout());
- Layout();
- }
-#else
- RenderWidgetHostViewChanged(tab_contents_->GetRenderWidgetHostView());
- native_container_->AttachContents(tab_contents_);
-#endif
- AddObservers();
- }
-}
-
-void TabContentsContainer::TabContentsFocused(TabContents* tab_contents) {
- if (native_container_)
- native_container_->TabContentsFocused(tab_contents);
-}
-
-void TabContentsContainer::SetFastResize(bool fast_resize) {
- if (native_container_)
- native_container_->SetFastResize(fast_resize);
-}
-
void TabContentsContainer::SetReservedContentsRect(
const gfx::Rect& reserved_rect) {
cached_reserved_rect_ = reserved_rect;
@@ -108,34 +54,10 @@ void TabContentsContainer::Observe(NotificationType type,
////////////////////////////////////////////////////////////////////////////////
// TabContentsContainer, View overrides:
-void TabContentsContainer::Layout() {
-#if defined(TOUCH_UI)
- views::View::Layout();
-#else
- if (native_container_) {
- native_container_->GetView()->SetBounds(0, 0, width(), height());
- native_container_->GetView()->Layout();
- }
-#endif
-}
-
AccessibilityTypes::Role TabContentsContainer::GetAccessibleRole() {
return AccessibilityTypes::ROLE_WINDOW;
}
-void TabContentsContainer::ViewHierarchyChanged(bool is_add,
- views::View* parent,
- views::View* child) {
-#if defined(TOUCH_UI)
- views::View::ViewHierarchyChanged(is_add, parent, child);
-#else
- if (is_add && child == this) {
- native_container_ = NativeTabContentsContainer::CreateNativeContainer(this);
- AddChildView(native_container_->GetView());
- }
-#endif
-}
-
////////////////////////////////////////////////////////////////////////////////
// TabContentsContainer, private:
@@ -156,17 +78,6 @@ void TabContentsContainer::RemoveObservers() {
registrar_.RemoveAll();
}
-void TabContentsContainer::RenderViewHostChanged(RenderViewHost* old_host,
- RenderViewHost* new_host) {
-#if defined(TOUCH_UI)
- NOTIMPLEMENTED(); // TODO(anicolao)
-#else
- if (new_host)
- RenderWidgetHostViewChanged(new_host->view());
- native_container_->RenderViewHostChanged(old_host, new_host);
-#endif
-}
-
void TabContentsContainer::TabContentsDestroyed(TabContents* contents) {
// Sometimes, a TabContents is destroyed before we know about it. This allows
// us to clean up our state in case this happens.

Powered by Google App Engine
This is Rietveld 408576698