Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 6023003: Add LaunchSelLdr to PPAPI... (Closed)

Created:
10 years ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, noelallen_use_chromium
Visibility:
Public.

Description

Add LaunchSelLdr and UrandomFD to PPAPI LaunchSelLdr just calls through to the webkit_glue backend, which calls through a bunch more layers of abstraction for us. UrandomFD returns the file descriptor of /dev/urandom (on Posix), which NaCl uses for some purpose by can't get directly because of the sandbox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69578

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M ppapi/c/private/ppb_nacl_util_private.h View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_nacl_util_private_impl.cc View 1 2 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
I'll re-run the try job once the LKGR catches up.
10 years ago (2010-12-17 20:18:47 UTC) #1
brettw
LGTM http://codereview.chromium.org/6023003/diff/8001/ppapi/c/private/ppb_nacl_util_private.h File ppapi/c/private/ppb_nacl_util_private.h (right): http://codereview.chromium.org/6023003/diff/8001/ppapi/c/private/ppb_nacl_util_private.h#newcode14 ppapi/c/private/ppb_nacl_util_private.h:14: bool (*LaunchSelLdr)(const char* alleged_url, int socket_count, Can you ...
10 years ago (2010-12-17 20:43:31 UTC) #2
abarth-chromium
10 years ago (2010-12-17 20:50:12 UTC) #3
http://codereview.chromium.org/6023003/diff/8001/ppapi/c/private/ppb_nacl_uti...
File ppapi/c/private/ppb_nacl_util_private.h (right):

http://codereview.chromium.org/6023003/diff/8001/ppapi/c/private/ppb_nacl_uti...
ppapi/c/private/ppb_nacl_util_private.h:14: bool (*LaunchSelLdr)(const char*
alleged_url, int socket_count,
On 2010/12/17 20:43:31, brettw wrote:
> Can you document this? Maybe there's someplace you can copy & paste from?

Will do.

http://codereview.chromium.org/6023003/diff/8001/ppapi/c/private/ppb_nacl_uti...
ppapi/c/private/ppb_nacl_util_private.h:18: int (*UrandomFD)(void);
On 2010/12/17 20:43:31, brettw wrote:
> This too, I don't have any idea what this even does.

Yep.  :)

Powered by Google App Engine
This is Rietveld 408576698