Fix setting a proxy configuration via policy that specifies a .pac file.

Fix setting a proxy configuration via policy that specifies a .pac file.

BUG=68099
TEST=manual testing of proxy policy

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70259

[danno, 2010-12-28 09:19:35]

please review (adding gabor since he's a committer and seems to be reading
email).

[battre, 2010-12-28 10:31:39]

Please find my comments. Also note the failed unit test that was added in the
recent CL.

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.grd (right):

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.grd:864:
http://www.chromium.org/administrators/policy-list-3/serious-problem</ex></ph>
for details about special considerations for this policy.
I cannot access this URL. (Page not found)

http://codereview.chromium.org/6021010/diff/2001/chrome/browser/policy/config...
File chrome/browser/policy/configuration_policy_pref_store.cc (right):

http://codereview.chromium.org/6021010/diff/2001/chrome/browser/policy/config...
chrome/browser/policy/configuration_policy_pref_store.cc:530: if (server ||
bypass_list) {
Here we should check for "|| pac_url" as well

[gfeher, 2010-12-28 11:30:03]

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.grd (right):

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.grd:864:
http://www.chromium.org/administrators/policy-list-3/serious-problem</ex></ph>
for details about special considerations for this policy.
The URL here is only an example value. This message is only used for policies
that define 'problem_href' in the JSON file. This placeholder will be replaced
with a link to the URL of 'problem_href'.

Currently there is only one such policy, MetricsReportingEnabled. BTW its page
claims that the problem was solved after Chrome 6.

[danno, 2010-12-28 12:17:54]

please take another look.

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.grd (right):

http://codereview.chromium.org/6021010/diff/2001/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.grd:864:
http://www.chromium.org/administrators/policy-list-3/serious-problem</ex></ph>
for details about special considerations for this policy.
Removed completely, since the policy states it is only officially supported
since Chrome 8.
On 2010/12/28 11:30:03, gfeher wrote:
> The URL here is only an example value. This message is only used for policies
> that define 'problem_href' in the JSON file. This placeholder will be replaced
> with a link to the URL of 'problem_href'.
> 
> Currently there is only one such policy, MetricsReportingEnabled. BTW its page
> claims that the problem was solved after Chrome 6.

http://codereview.chromium.org/6021010/diff/2001/chrome/browser/policy/config...
File chrome/browser/policy/configuration_policy_pref_store.cc (right):

http://codereview.chromium.org/6021010/diff/2001/chrome/browser/policy/config...
chrome/browser/policy/configuration_policy_pref_store.cc:530: if (server ||
bypass_list) {
On 2010/12/28 10:31:39, battre wrote:
> Here we should check for "|| pac_url" as well

Done.

[battre, 2010-12-28 14:49:56]

I don't have any further comments.

[gfeher, 2010-12-28 22:41:52]

LGTM