Mac: Enable "Check Spelling While Typing" in Edit menu...

chrome/browser/renderer_host/render_view_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_view_host.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 343 matching lines @@
                                                    int request_id) {
   CrossSiteRequestManager::GetInstance()->SetHasPendingCrossSiteRequest(
       process()->id(), routing_id(), has_pending_request);
   pending_request_id_ = request_id;
 }
 
 int RenderViewHost::GetPendingRequestId() {
   return pending_request_id_;
 }
 
+RenderViewHost::CommandState RenderViewHost::GetStateForCommand(
+    const std::string& command_name) const {
+  std::map<std::string, CommandState>::const_iterator it =

[brettw, 2011/01/09 00:06:06]

A couple of comments on this: where does the command name come from? Can it be
some kind of enum?

It also seems weird to me that this defaults to "not enabled". This means if I
call GetStateForCommand("reload") it will return false which is probably not
what we want. This is another thing that would be helped by an enum.

[sail, 2011/01/11 18:45:51]

Enum sounds good. Should I put it in render_messages_internal.h?
How about not enabled by default and assert if an unknown command type is sent.
If the render process hasn't update the command state yet then it would be weird
to allow the user to execute the command.

[sail, 2011/01/12 01:26:36]

Done.

+    command_states_.find(command_name);

[brettw, 2011/01/09 00:06:06]

Style nit: wrapped lines get indented 4 spaces

[sail, 2011/01/12 01:26:36]

Done.

+  if (it == command_states_.end()) {
+    CommandState state;
+    state.is_enabled = false;
+    state.checked_state = 0;
+    return state;
+  }
+  return it->second;
+}
+
 void RenderViewHost::Stop() {
   Send(new ViewMsg_Stop(routing_id()));
 }
 
 void RenderViewHost::ReloadFrame() {
   Send(new ViewMsg_ReloadFrame(routing_id()));
 }
 
 bool RenderViewHost::PrintPages() {
   return Send(new ViewMsg_PrintPages(routing_id()));
@@ skipping 501 matching lines @@
     IPC_MESSAGE_HANDLER(ViewHostMsg_DetectedPhishingSite,
                         OnDetectedPhishingSite)
     IPC_MESSAGE_HANDLER(ViewHostMsg_ScriptEvalResponse, OnScriptEvalResponse)
     IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateContentRestrictions,
                         OnUpdateContentRestrictions)
 #if defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(ViewHostMsg_ShowPopup, OnMsgShowPopup)
 #endif
     IPC_MESSAGE_HANDLER(ViewHostMsg_PagesReadyForPreview,
                         OnPagesReadyForPreview)
+    IPC_MESSAGE_HANDLER(ViewHostMsg_CommandStateChanged,
+                        OnCommandStateChanged)
     // Have the super handle all other messages.
     IPC_MESSAGE_UNHANDLED(handled = RenderWidgetHost::OnMessageReceived(msg))
   IPC_END_MESSAGE_MAP_EX()
 
   if (!msg_is_ok) {
     // The message had a handler, but its de-serialization failed.
     // Kill the renderer.
     UserMetrics::RecordAction(UserMetricsAction("BadMessageTerminate_RVH"));
     process()->ReceivedBadMessage();
   }
@@ skipping 1285 matching lines @@
   if (printer_query.get()) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         NewRunnableMethod(printer_query.get(),
                           &printing::PrinterQuery::StopWorker));
   }
 
   // Send the printingDone msg for now.
   Send(new ViewMsg_PrintingDone(routing_id(), params.document_cookie, true));
 }
+
+void RenderViewHost::OnCommandStateChanged(std::string command_name,
+                                           bool is_enabled,
+                                           int checked_state) {
+  CommandState state;
+  state.is_enabled = is_enabled;
+  state.checked_state = checked_state;
+  command_states_[command_name] = state;
+}