Mac: Enable "Check Spelling While Typing" in Edit menu...

chrome/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 23 matching lines @@
 #include "chrome/common/database_messages.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/file_system/file_system_dispatcher.h"
 #include "chrome/common/file_system/webfilesystem_callback_dispatcher.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/page_zoom.h"
 #include "chrome/common/pepper_plugin_registry.h"
 #include "chrome/common/render_messages.h"
+#include "chrome/common/render_view_commands.h"
 #include "chrome/common/renderer_preferences.h"
 #include "chrome/common/thumbnail_score.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/common/web_apps.h"
 #include "chrome/common/window_container_type.h"
 #include "chrome/renderer/about_handler.h"
 #include "chrome/renderer/audio_message_filter.h"
 #include "chrome/renderer/autofill_helper.h"
 #include "chrome/renderer/automation/dom_automation_controller.h"
 #include "chrome/renderer/blocked_plugin.h"
@@ skipping 1572 matching lines @@
   UserMetricsRecordAction("SelectAll");
 }
 
 void RenderView::OnSetInitialFocus(bool reverse) {
   if (!webview())
     return;
   webview()->setInitialFocus(reverse);
 }
 
 void RenderView::OnScrollFocusedEditableNodeIntoView() {
-  if (!webview())
-    return;
-  WebFrame* focused_frame = webview()->focusedFrame();
-  if (focused_frame) {
-    WebDocument doc = focused_frame->document();
-    if (!doc.isNull()) {
-      WebNode node = doc.focusedNode();
-      if (IsEditableNode(node))
-        // TODO(varunjain): Change webkit API to scroll a particular node into
-        // view and use that API here instead.
-        webview()->scrollFocusedNodeIntoView();
-    }
+  WebNode node;
+  if (GetFocusedNode(node)) {
+    if (IsEditableNode(node))
+      // TODO(varunjain): Change webkit API to scroll a particular node into
+      // view and use that API here instead.
+      webview()->scrollFocusedNodeIntoView();
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 void RenderView::SetContentSettings(const ContentSettings& settings) {
   current_content_settings_ = settings;
 }
 
 // Tell the embedding application that the URL of the active page has changed
@@ skipping 749 matching lines @@
 
 bool RenderView::isShowingSpellingUI() {
   return spelling_panel_visible_;
 }
 
 void RenderView::updateSpellingUIWithMisspelledWord(const WebString& word) {
   Send(new ViewHostMsg_UpdateSpellingPanelWithMisspelledWord(routing_id_,
                                                              word));
 }
 
+void RenderView::continuousSpellCheckingEnabledStateChanged() {
+  UpdateToggleSpellCheckCommandState();
+}
+
 bool RenderView::runFileChooser(
     const WebKit::WebFileChooserParams& params,
     WebFileChooserCompletion* chooser_completion) {
   // Do not open the file dialog in a hidden RenderView.
   if (is_hidden())
     return false;
   ViewHostMsg_RunFileChooser_Params ipc_params;
   if (params.directory)
     ipc_params.mode = ViewHostMsg_RunFileChooser_Params::OpenFolder;
   else if (params.multiSelect)
@@ skipping 106 matching lines @@
     // any existing pending sends.
     pending_target_url_ = latest_url;
     target_url_status_ = TARGET_PENDING;
   } else {
     Send(new ViewHostMsg_UpdateTargetURL(routing_id_, page_id_, latest_url));
     target_url_ = latest_url;
     target_url_status_ = TARGET_INFLIGHT;
   }
 }
 
+void RenderView::UpdateToggleSpellCheckCommandState() {
+  bool is_enabled = false;
+  WebNode node;
+  if (GetFocusedNode(node))
+    is_enabled = IsEditableNode(node);
+
+  CommandCheckedState checked_state = COMMAND_CHECKED_STATE_UNCHECKED;
+  if (is_enabled && webview()) {
+    WebFrame* frame = webview()->focusedFrame();
+    if (frame->isContinuousSpellCheckingEnabled()) {

[brettw, 2011/01/13 05:59:55]

Use {} for single-line conditionals consistently. Normally this means we don't
use {}

[sail, 2011/01/13 23:38:15]

Done.

+      checked_state = COMMAND_CHECKED_STATE_CHECKED;
+    }
+  }
+
+  Send(new ViewHostMsg_CommandStateChanged(
+      routing_id_,
+      RENDER_VIEW_COMMAND_TOGGLE_SPELL_CHECK,
+      is_enabled,
+      checked_state));
+}
+
 void RenderView::StartNavStateSyncTimerIfNecessary() {
   int delay;
   if (send_content_state_immediately_)
     delay = 0;
   else if (is_hidden())
     delay = kDelaySecondsForContentStateSyncHidden;
   else
     delay = kDelaySecondsForContentStateSync;
 
   if (nav_state_sync_timer_.IsRunning()) {
@@ skipping 56 matching lines @@
 void RenderView::focusedNodeChanged(const WebNode& node) {
   Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, IsEditableNode(node)));
 
   if (WebAccessibilityCache::accessibilityEnabled() && node.isNull()) {
     // TODO(ctguil): Make WebKit send this notification.
     // When focus is cleared notify accessibility that the document is focused.
     postAccessibilityNotification(
         webview()->accessibilityObject(),
         WebKit::WebAccessibilityNotificationFocusedUIElementChanged);
   }
+
+  UpdateToggleSpellCheckCommandState();
 }
 
 void RenderView::navigateBackForwardSoon(int offset) {
   Send(new ViewHostMsg_GoToEntryAtOffset(routing_id_, offset));
 }
 
 int RenderView::historyBackListCount() {
   return history_list_offset_ < 0 ? 0 : history_list_offset_;
 }
 
@@ skipping 1952 matching lines @@
       xpath_remaining.erase(0, delim_pos + 1);
     } else {
       xpath_remaining.swap(xpath_child);
     }
     frame = frame->findChildByExpression(WideToUTF16Hack(xpath_child));
   }
 
   return frame;
 }
 
+bool RenderView::GetFocusedNode(WebNode& node) const {
+  if (!webview())
+    return false;
+  WebFrame* focused_frame = webview()->focusedFrame();
+  if (focused_frame) {
+    WebDocument doc = focused_frame->document();
+    if (!doc.isNull()) {
+      node = doc.focusedNode();
+      return true;
+    }
+  }
+
+  return false;
+}
+
 void RenderView::SetSuggestions(const std::vector<std::string>& suggestions) {
   // Explicitly allow empty vector to be sent to the browser.
   Send(new ViewHostMsg_SetSuggestions(routing_id_, page_id_, suggestions));
 }
 
 void RenderView::EvaluateScript(const string16& frame_xpath,
                                 const string16& script,
                                 int id,
                                 bool notify_result) {
   v8::Handle<v8::Value> result;
@@ skipping 1186 matching lines @@
 }
 #endif
 
 void RenderView::OnJavaScriptStressTestControl(int cmd, int param) {
   if (cmd == kJavaScriptStressTestSetStressRunType) {
     v8::Testing::SetStressRunType(static_cast<v8::Testing::StressType>(param));
   } else if (cmd == kJavaScriptStressTestPrepareStressRun) {
     v8::Testing::PrepareStressRun(param);
   }
 }