Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: src/x64/assembler-x64.h

Issue 6020012: Cleanup of x64 code. Rearrange functions in ic-x64.cc to match order in ic-i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 static const int kRealPatchReturnSequenceAddressOffset = 2; 529 static const int kRealPatchReturnSequenceAddressOffset = 2;
530 530
531 // The x64 JS return sequence is padded with int3 to make it large 531 // The x64 JS return sequence is padded with int3 to make it large
532 // enough to hold a call instruction when the debugger patches it. 532 // enough to hold a call instruction when the debugger patches it.
533 static const int kCallInstructionLength = 13; 533 static const int kCallInstructionLength = 13;
534 static const int kJSReturnSequenceLength = 13; 534 static const int kJSReturnSequenceLength = 13;
535 535
536 // The debug break slot must be able to contain a call instruction. 536 // The debug break slot must be able to contain a call instruction.
537 static const int kDebugBreakSlotLength = kCallInstructionLength; 537 static const int kDebugBreakSlotLength = kCallInstructionLength;
538 538
539 // One byte opcode for test eax,0xXXXXXXXX.
540 static const byte kTestEaxByte = 0xA9;
539 541
540 // --------------------------------------------------------------------------- 542 // ---------------------------------------------------------------------------
541 // Code generation 543 // Code generation
542 // 544 //
543 // Function names correspond one-to-one to x64 instruction mnemonics. 545 // Function names correspond one-to-one to x64 instruction mnemonics.
544 // Unless specified otherwise, instructions operate on 64-bit operands. 546 // Unless specified otherwise, instructions operate on 64-bit operands.
545 // 547 //
546 // If we need versions of an assembly instruction that operate on different 548 // If we need versions of an assembly instruction that operate on different
547 // width arguments, we add a single-letter suffix specifying the width. 549 // width arguments, we add a single-letter suffix specifying the width.
548 // This is done for the following instructions: mov, cmp, inc, dec, 550 // This is done for the following instructions: mov, cmp, inc, dec,
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
1496 private: 1498 private:
1497 Assembler* assembler_; 1499 Assembler* assembler_;
1498 #ifdef DEBUG 1500 #ifdef DEBUG
1499 int space_before_; 1501 int space_before_;
1500 #endif 1502 #endif
1501 }; 1503 };
1502 1504
1503 } } // namespace v8::internal 1505 } } // namespace v8::internal
1504 1506
1505 #endif // V8_X64_ASSEMBLER_X64_H_ 1507 #endif // V8_X64_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698