Issue 6020012: Cleanup of x64 code. Rearrange functions in ic-x64.cc to match order in ic-i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6020012: Cleanup of x64 code. Rearrange functions in ic-x64.cc to match order in ic-i... (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Cleanup of x64 code. Rearrange functions in ic-x64.cc to match order in ic-ia32.cc. Remove unused declarations, and move a constant to assembler-x64.h. Committed: http://code.google.com/p/v8/source/detail?r=6143

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+306 lines, -319 lines)			Patch
M	src/ia32/ic-ia32.cc	View	1	4 chunks	+0 lines, -13 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	1	6 chunks	+75 lines, -71 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	16 chunks	+229 lines, -235 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Only changes besides moving functions around in ic-x64.cc is replacement of kTestEaxByte with Assembler::kTestEaxByte, and ...

9 years, 11 months ago (2011-01-03 15:07:33 UTC) #1

LGTM

Expand Messages | Collapse Messages