Destroy svn_utils.py.

Destroy svn_utils.py.

Follow Peter's advice and move most svn_utils functions into a MixIn class.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70065

[M-A Ruel, 2010-12-22 17:34:57]

Dependent on http://codereview.chromium.org/6014008/

[Dirk Pranke, 2010-12-22 23:18:09]

LGTM with the change, unless I'm mistaken and that call is used elsewhere as
well, in which case it's fine where it is.

http://codereview.chromium.org/6020010/diff/1/checkout.py
File checkout.py (right):

http://codereview.chromium.org/6020010/diff/1/checkout.py#newcode72
checkout.py:72: def _capture_svn(self, args, **kwargs):
This is only used by SvnCheckout, right? If so, I would move it there to
minimize confusion.

[M-A Ruel, 2010-12-23 17:19:49]

http://codereview.chromium.org/6020010/diff/1/checkout.py
File checkout.py (right):

http://codereview.chromium.org/6020010/diff/1/checkout.py#newcode72
checkout.py:72: def _capture_svn(self, args, **kwargs):
On 2010/12/22 23:18:10, dpranke wrote:
> This is only used by SvnCheckout, right? If so, I would move it there to
> minimize confusion.

Ok, I'll move it in a later change otherwise it creates a few conflicts in the
next changes.

[M-A Ruel, 2010-12-23 17:21:07]

On 2010/12/23 17:19:49, Marc-Antoine Ruel wrote:
> Ok, I'll move it in a later change otherwise it creates a few conflicts in the
> next changes.

Actually I was wrong, it's eventually used in
GitSvnCheckoutBase._cache_svn_auth() so I'll leave it there.

[commit-bot: I haz the power, 2010-12-23 17:21:30]

Patch failed to apply against 70061.