Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 6019008: Add back building of policy templates to the official builders (Closed)

Created:
9 years, 11 months ago by gfeher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Glenn Wilson
Visibility:
Public.

Description

Add back building of policy templates to the official builders BUG=68562 TEST=policy_templates.zip should reappear in the offical builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70495

Patch Set 1 #

Patch Set 2 : alphabet fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gfeher
Please review.
9 years, 11 months ago (2011-01-04 23:13:13 UTC) #1
nsylvain
LGTM, but, What does it do? What component of the builds need it? Should this ...
9 years, 11 months ago (2011-01-04 23:14:52 UTC) #2
gfeher
This generates ADM,ADMX and similar policy templates for the Chrome enterprise policies. They can be ...
9 years, 11 months ago (2011-01-04 23:21:32 UTC) #3
gfeher
To sum up: > What component of the builds need it? No other build components ...
9 years, 11 months ago (2011-01-05 09:29:57 UTC) #4
nsylvain
9 years, 11 months ago (2011-01-05 18:39:45 UTC) #5
On Wed, Jan 5, 2011 at 1:29 AM, <gfeher@chromium.org> wrote:

> To sum up:
>
>
>  What component of the builds need it?
>>
> No other build components need this, users need the resulting .zip file.
> But
> only system administrators would use this, that's why we have decided not
> to
> ship with regular Chrome downloads.
>
>
>  Should this be a dependency in mini_installer ?
>>
> I believe no.


Sounds good


>
>
> http://codereview.chromium.org/6019008/
>

Powered by Google App Engine
This is Rietveld 408576698