Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 6019007: Remove win_util::FormatMessage and FormatLastWin32Error. These were only used... (Closed)

Created:
9 years, 12 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, pam+watch_chromium.org, amit, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove win_util::FormatMessage and FormatLastWin32Error. These were only used in a couple of diagnostic places and one can always use the "Error Lookup" utility. Move window HWND-specific functions from base/win_util.h to a new file app/win/hwnd_util.h. I plan to put some more stuff from app/win_util into this file as well. Move gfx/window_impl.h into app/win TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70312

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -558 lines) Patch
M app/app_base.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
A app/win/hwnd_util.h View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A app/win/hwnd_util.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M app/win/scoped_prop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + app/win/window_impl.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + app/win/window_impl.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download
M base/file_util_win.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M base/win_util.h View 3 chunks +0 lines, -19 lines 0 comments Download
M base/win_util.cc View 3 chunks +0 lines, -67 lines 0 comments Download
M base/win_util_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/default_plugin/plugin_impl_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gfx/canvas_direct2d_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M gfx/gfx.gyp View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
D gfx/window_impl.h View 1 chunk +0 lines, -114 lines 0 comments Download
D gfx/window_impl.cc View 1 chunk +0 lines, -230 lines 0 comments Download
M tools/memory_watcher/hotkey.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/native_control.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/native_control_win.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/table/native_table_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/table/table_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/tree/tree_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/focus/focus_util_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M views/widget/widget_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/widget_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/window/window_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/foreground_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 11 chunks +12 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 12 months ago (2010-12-29 22:47:05 UTC) #1
jam
9 years, 12 months ago (2010-12-29 23:42:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698