Mark CloudPrintURLFetcherBasicTest.HandleRawResponse FLAKY because of...

Mark CloudPrintURLFetcherBasicTest.HandleRawResponse FLAKY because of
intermittent failures on Mac. Update comments for HandleRawData and
GiveUp to point at bug 60426 rather than bug 62758.

BUG=60426
TEST=none
TBR=sanjeevr


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70227

[Ken Russell (switch to Gerrit), 2010-12-28 17:41:00]

FYI.

[Paweł Hajdan Jr., 2011-01-03 09:25:34]

FYI, FLAKY_ won't help with the crashes. If you want to change something,
please use DISABLED.

On Tue, Dec 28, 2010 at 18:41, <kbr@chromium.org> wrote:

> Reviewers: sanjeevr,
>
> Message:
> FYI.
>
>
> Description:
> Mark CloudPrintURLFetcherBasicTest.HandleRawResponse FLAKY because of
> intermittent failures on Mac. Update comments for HandleRawData and
> GiveUp to point at bug 60426 rather than bug 62758.
>
> BUG=60426
> TEST=none
> TBR=sanjeevr
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70227
>
> Please review this at http://codereview.chromium.org/6018009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>
>
> Index: chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
> ===================================================================
> --- chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  (revision 70225)
> +++ chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  (working copy)
> @@ -291,7 +291,8 @@
>   io_message_loop_proxy()->PostTask(FROM_HERE, new
> MessageLoop::QuitTask());
>  }
>
> -TEST_F(CloudPrintURLFetcherBasicTest, HandleRawResponse) {
> +// http://code.google.com/p/chromium/issues/detail?id=60426
> +TEST_F(CloudPrintURLFetcherBasicTest, FLAKY_HandleRawResponse) {
>   net::TestServer test_server(net::TestServer::TYPE_HTTP,
> FilePath(kDocRoot));
>   ASSERT_TRUE(test_server.Start());
>   SetHandleRawResponse(true);
> @@ -300,7 +301,7 @@
>   MessageLoop::current()->Run();
>  }
>
> -// http://code.google.com/p/chromium/issues/detail?id=62758
> +// http://code.google.com/p/chromium/issues/detail?id=60426
>  TEST_F(CloudPrintURLFetcherBasicTest, FLAKY_HandleRawData) {
>   net::TestServer test_server(net::TestServer::TYPE_HTTP,
> FilePath(kDocRoot));
>   ASSERT_TRUE(test_server.Start());
> @@ -330,7 +331,7 @@
>   net::URLRequestThrottlerManager::GetInstance()->EraseEntryForTests(url);
>  }
>
> -// http://code.google.com/p/chromium/issues/detail?id=62758
> +// http://code.google.com/p/chromium/issues/detail?id=60426
>  TEST_F(CloudPrintURLFetcherRetryBackoffTest, FLAKY_GiveUp) {
>   net::TestServer test_server(net::TestServer::TYPE_HTTP,
> FilePath(kDocRoot));
>   ASSERT_TRUE(test_server.Start());
>
>
>