Issue 6017008: Add fine-grained diff implementation to LiveEdit engine.

Issue 6017008: Add fine-grained diff implementation to LiveEdit engine. (Closed)

Created:
10 years ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add fine-grained diff implementation to LiveEdit engine. BUG=1013 TEST= Committed: http://code.google.com/p/v8/source/detail?r=6274

Patch Set 5 : drop linewise suffix, some fixes #

Patch Set 7 : follow codereview #

Patch Set 8 : merge #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -40 lines)			Patch
M	src/liveedit.h	View	1 2 3 4	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View	1 2 3 4 5 6	3 chunks	+105 lines, -18 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1 2 3 4 5	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/runtime.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -4 lines	0 comments	Download
M	test/mjsunit/debug-liveedit-diff.js	View	1 2 3 4	3 chunks	+20 lines, -7 lines	0 comments	Download
M	test/mjsunit/debug-liveedit-newsource.js	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM with comments addressed. http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode309 src/liveedit.cc:309: TokensCompareInput(Handle<String> s1, int offset1, int ...

9 years, 11 months ago (2011-01-03 09:46:54 UTC) #2

Peter Rybin

9 years, 11 months ago (2011-01-11 14:49:56 UTC) #3

Thank you for review. Sorry about code style issues -- still a problem to switch
brain between several codebases with opposite recommendations :)

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode309
src/liveedit.cc:309: TokensCompareInput(Handle<String> s1, int offset1, int
len1,
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Only 2 char indentation of constructor, and align arguments.

Done.

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode314
src/liveedit.cc:314: int getLength1() {
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Please use getter name len1, see
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi....

They are not getters, they are implementations of virtual methods. I added
"virtual" keyword.

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode317
src/liveedit.cc:317: int getLength2() {
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Ditto.

See above.

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode337
src/liveedit.cc:337: public:
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Only 2 char indentation of constructor.

Done.

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode432
src/liveedit.cc:432: public:
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/6017008/diff/12001/src/liveedit.cc#newcode445
src/liveedit.cc:445: if (char_len1 < CHUNK_LEN_LIMIT && char_len2 <
CHUNK_LEN_LIMIT) {
On 2011/01/03 09:46:54, Søren Gjesse wrote:
> Indentation.

Done.

Expand Messages | Collapse Messages