Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6017002: DOMUI Settings: UTH: Remove the 'Reset to Defaults' button. (Closed)

Created:
10 years ago by kmadhusu
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI Settings: UTH: Remove the 'Reset to Defaults' button. BUG=66115 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69581

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/options/options_util.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kmadhusu
10 years ago (2010-12-17 18:51:33 UTC) #1
James Hawkins
LGTM. Add a TODO to OptionsUtil to remove ResetToDefaults.
10 years ago (2010-12-17 19:54:31 UTC) #2
kmadhusu
10 years ago (2010-12-17 20:47:38 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698