Issue 6017001: Move ElideString() from base/string_util.cc to app/text_elider.cc to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6017001: Move ElideString() from base/string_util.cc to app/text_elider.cc to ... (Closed)

Created:
10 years ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, davemoore+watch_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Move ElideString() from base/string_util.cc to app/text_elider.cc to reduce size of widely-included base libraries. Committing for tsepez. BUG=49747 TEST=TextEliderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69555

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -89 lines)			Patch
M	app/text_elider.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	app/text_elider.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	app/text_elider_unittest.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	base/string_util.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/string_util.cc	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/chromeos/external_protocol_dialog.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/external_protocol_dialog_gtk.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_entry.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_controller.mm	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/external_protocol_dialog.mm	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download_item_view.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/external_protocol_dialog.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download