Issue 6015016: Some clean ups to build/common.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6015016: Some clean ups to build/common.gypi. (Closed)

Created:
9 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/build

Visibility:
Public.

Description

Some clean ups to build/common.gypi. - Organizing variables dicts as 1) vars copied from inner scopes 2) new vars defined in current scope 3) conditions - moving variables out of inner scopes when possible - cleaning up/consolidating some comments This is just a refactoring and shouldn't change any of the logic. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70667

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -98 lines)			Patch
	M	build/common.gypi	View	1	6 chunks	+91 lines, -98 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

If it works, it LGTM.

Expand Messages | Collapse Messages