Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 6015015: Allow methods and signals on the org.freedesktop.DBus.Properties interface. (Closed)

Created:
9 years, 11 months ago by Eric Shienbrood
Modified:
9 years, 7 months ago
Reviewers:
Jason Glasgow, rochberg
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Allow methods and signals on the org.freedesktop.DBus.Properties interface. This is needed to allow cromo plugins to send the MmPropertiesChanged modem manager signal. BUG=chromium-os:4667 TEST=Build cromo. Compare generated files before and after this change. Observe that the code generated for mm-modem.xml now defines MmPropertiesChanged, where before it did not. Checked that nothing else has changed in the generated code. Change-Id: Ida5e3d76133f6ed82c2bd49ca1599a0948914aa1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d1d60eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/generate_adaptor.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Eric Shienbrood
9 years, 11 months ago (2011-01-05 16:18:22 UTC) #1
Jason Glasgow
9 years, 11 months ago (2011-01-05 16:48:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698