Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 6015013: Major cleanup of cros_au_test_harness code. (Closed)

Created:
9 years, 11 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Major cleanup of cros_au_test_harness code. This cleanup code consolidates parsing of options, removes globals, cleans up private vs. public functions, removes the backup full update option, and cleans up docstrings. Change-Id: I3eba26b3634fd87f4a36f195ab42ec7bd11e963f BUG=chromium-os:8901 TEST=Ran with prefix SimpleTest and ran whole suite for a vm using my latest built image. Also ran normal update test using latest image against latest dev channel image for mario. Re-tested with new changes after build break. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2b2d7a1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8617623

Patch Set 1 #

Patch Set 2 : Fix bugs found while testing #

Total comments: 3

Patch Set 3 : Nits #

Patch Set 4 : Fix bug petkov found + add docstring to module. #

Patch Set 5 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -168 lines) Patch
M bin/cros_au_test_harness.py View 1 2 3 4 24 chunks +188 lines, -168 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
Just a cleanup CL. Don's out so I think you're the next best reviewer.
9 years, 11 months ago (2011-01-05 00:10:34 UTC) #1
petkov
LGTM with a couple of nits. http://codereview.chromium.org/6015013/diff/2001/bin/cros_au_test_harness.py File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/6015013/diff/2001/bin/cros_au_test_harness.py#newcode3 bin/cros_au_test_harness.py:3: # Copyright (c) ...
9 years, 11 months ago (2011-01-05 00:57:48 UTC) #2
sosa
PTAL (third diff). I rebased this off TOT and fixed the bug you caught (flip ...
9 years, 11 months ago (2011-01-10 21:16:48 UTC) #3
petkov
9 years, 11 months ago (2011-01-10 21:26:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698