src/x64/macro-assembler-x64.cc - Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

===================================================================

--- src/x64/macro-assembler-x64.cc (revision 6129)

+++ src/x64/macro-assembler-x64.cc (working copy)

@@ -1110,7 +1110,7 @@

void MacroAssembler::SmiAndConstant(Register dst, Register src, Smi* constant) {

if (constant->value() == 0) {

- xor_(dst, dst);

+ Set(dst, 0);

} else if (dst.is(src)) {

ASSERT(!dst.is(kScratchRegister));

@@ -1605,7 +1605,7 @@

#ifdef ENABLE_DEBUGGER_SUPPORT

void MacroAssembler::DebugBreak() {

ASSERT(allow_stub_calls());

- xor_(rax, rax); // no arguments

+ Set(rax, 0); // No arguments.

movq(rbx, ExternalReference(Runtime::kDebugBreak));

CEntryStub ces(1);

Call(ces.GetCode(), RelocInfo::DEBUG_BREAK);

« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | src/x64/regexp-macro-assembler-x64.cc » ('j') | no next file with comments »