Adding tests for plugins section in content settings....

Adding tests for plugins section in content settings.

1. testBlockAllPlugins
2. testAllowPluginException
3. testBlockPluginException

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71505

[Nirnimesh, 2011-01-07 22:44:23]

Minor comments

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py
File functional/plugins.py (right):

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:143: """Verify that all the plugins are blocked."""
s/are/can be/

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:143: """Verify that all the plugins are blocked."""
Add: Verifies by checking that flash plugin was blocked

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:144: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
it's ok to move all args from self.DataDir() to next line

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:147: pid = self._GetPluginPID('Shockwave Flash')
s/pid/flash_pid/

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:149: self.Kill(pid)
Is it necessary to Kill?

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:167: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
repeat

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:184: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
repeat

[sunandt, 2011-01-13 00:29:34]

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py
File functional/plugins.py (right):

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:143: """Verify that all the plugins are blocked."""
On 2011/01/07 22:44:23, Nirnimesh wrote:
> s/are/can be/

Done.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:143: """Verify that all the plugins are blocked."""
On 2011/01/07 22:44:23, Nirnimesh wrote:
> Add: Verifies by checking that flash plugin was blocked

Done.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:144: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
On 2011/01/07 22:44:23, Nirnimesh wrote:
> it's ok to move all args from self.DataDir() to next line

Done.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:147: pid = self._GetPluginPID('Shockwave Flash')
On 2011/01/07 22:44:23, Nirnimesh wrote:
> s/pid/flash_pid/

Done.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:149: self.Kill(pid)
On 2011/01/07 22:44:23, Nirnimesh wrote:
> Is it necessary to Kill?
Yes. Because the flash process is not killed immediately.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:167: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
On 2011/01/07 22:44:23, Nirnimesh wrote:
> repeat

Done.

http://codereview.chromium.org/6015010/diff/2001/functional/plugins.py#newcod...
functional/plugins.py:184: flash_url =
self.GetFileURLForPath(os.path.join(self.DataDir(),
On 2011/01/07 22:44:23, Nirnimesh wrote:
> repeat

Done.

[Nirnimesh, 2011-01-14 21:54:33]

LGTM