Issue 6014009: Update menu icons for dynamic items when we update the label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6014009: Update menu icons for dynamic items when we update the label. (Closed)

Created:
10 years ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Update menu icons for dynamic items when we update the label. BUG=66508 TEST=enable background mode, see wrench menu badge toggle when extensions load Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70228

Patch Set 1 #

Patch Set 2 : Removed broken handling of case with no initial icon. #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	chrome/browser/gtk/menu_gtk.cc	View	1	2 chunks	+11 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

This is a follow-up to that previous review you did for me a bit ago. ...

10 years ago (2010-12-23 01:57:51 UTC) #1

Evan Stade

http://codereview.chromium.org/6014009/diff/3001/chrome/browser/gtk/menu_gtk.cc File chrome/browser/gtk/menu_gtk.cc (right): http://codereview.chromium.org/6014009/diff/3001/chrome/browser/gtk/menu_gtk.cc#newcode814 chrome/browser/gtk/menu_gtk.cc:814: gtk_label_set_label(GTK_LABEL(GTK_BIN(widget)->child), label.c_str()); side note. I wonder if this actually ...

10 years ago (2010-12-23 02:36:42 UTC) #3

Andrew T Wilson (Slow)

On 2010/12/23 02:36:42, Evan Stade wrote: > I wonder if this actually works for GtkImageMenuItems... ...

10 years ago (2010-12-23 02:54:27 UTC) #4

Andrew T Wilson (Slow)

10 years ago (2010-12-23 02:59:52 UTC) #5

On 2010/12/23 02:54:27, Andrew T Wilson wrote:
> On 2010/12/23 02:36:42, Evan Stade wrote:
> > I wonder if this actually works for GtkImageMenuItems...

Just checking - is there any reason to avoid landing this change, since it's not
really affecting the code you're concerned about anyway?

Expand Messages | Collapse Messages