Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 6014007: Improve documentation for the tools for generating size checks, based on comm... (Closed)

Created:
10 years ago by dmichael(do not use this one)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Improve documentation for the tools for generating size checks, based on comments on: http://codereview.chromium.org/5730003/ Also automated handling of long and unsigned long as suggested in review comments for that CL. BUG=None TEST=Reran generate_ppapi_size_checks.py; produced the same output. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69950

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -82 lines) Patch
M ppapi/generate_ppapi_size_checks.py View 1 10 chunks +137 lines, -51 lines 0 comments Download
M ppapi/tests/clang/README View 1 chunk +42 lines, -17 lines 0 comments Download
M ppapi/tests/clang/print_names_and_sizes.cc View 4 chunks +34 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmichael(do not use this one)
10 years ago (2010-12-21 22:25:23 UTC) #1
David Springer
10 years ago (2010-12-21 23:08:20 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698