Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 6014003: Intergration of the client-side phishing detection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove comment Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_service.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h
index fcc823d7e5a24e3cd717f8b04d131cabcd769a70..2c372027e76ef458fa184802dea98ca5a36ca5ac 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.h
+++ b/chrome/browser/safe_browsing/client_side_detection_service.h
@@ -91,11 +91,16 @@ class ClientSideDetectionService : public URLFetcher::Delegate,
// fetch. If an error occurs the phishing verdict will always be false. The
// callback is always called after SendClientReportPhishingRequest() returns
// and on the same thread as SendClientReportPhishingRequest() was called.
- void SendClientReportPhishingRequest(
+ virtual void SendClientReportPhishingRequest(
const GURL& phishing_url,
double score,
ClientReportPhishingRequestCallback* callback);
+ protected:
+ // Use Create() method to create an instance of this object.
+ ClientSideDetectionService(const FilePath& model_path,
+ URLRequestContextGetter* request_context_getter);
+
private:
friend class ClientSideDetectionServiceTest;
friend class ClientSideDetectionServiceHooksTest;
@@ -127,10 +132,6 @@ class ClientSideDetectionService : public URLFetcher::Delegate,
static const base::TimeDelta kNegativeCacheInterval;
static const base::TimeDelta kPositiveCacheInterval;
- // Use Create() method to create an instance of this object.
- ClientSideDetectionService(const FilePath& model_path,
- URLRequestContextGetter* request_context_getter);
-
// Sets the model status and invokes all the pending callbacks in
// |open_callbacks_| with the current |model_file_| as parameter.
void SetModelStatus(ModelStatus status);

Powered by Google App Engine
This is Rietveld 408576698