Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 6014003: Intergration of the client-side phishing detection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Dont DCHECK because some unit tests are failing. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_service.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h
index a9bc7f6966ddfb82ccc5d9ce970795b6ddc8ea58..51312b657e41c7f0bffea4c8f9672fd89d8e2afb 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.h
+++ b/chrome/browser/safe_browsing/client_side_detection_service.h
@@ -31,7 +31,9 @@
#include "base/scoped_ptr.h"
#include "base/task.h"
#include "base/time.h"
+#include "chrome/common/render_messages_params.h"
#include "chrome/browser/safe_browsing/csd.pb.h"
+#include "chrome/browser/tab_contents/navigation_controller.h"
lzheng 2011/02/11 19:39:42 From the changes, it is not obvious to me hy these
noelutz 2011/02/15 23:00:55 Done.
#include "chrome/common/net/url_fetcher.h"
#include "googleurl/src/gurl.h"
@@ -82,11 +84,15 @@ class ClientSideDetectionService : public URLFetcher::Delegate {
// fetch. If an error occurs the phishing verdict will always be false. The
// callback is always called after SendClientReportPhishingRequest() returns
// and on the same thread as SendClientReportPhishingRequest() was called.
- void SendClientReportPhishingRequest(
+ virtual void SendClientReportPhishingRequest(
const GURL& phishing_url,
double score,
ClientReportPhishingRequestCallback* callback);
+ protected:
+ // Used for testing only.
+ ClientSideDetectionService();
+
private:
friend class ClientSideDetectionServiceTest;

Powered by Google App Engine
This is Rietveld 408576698