Issue 60115: DevTools: tell agent it has client attached early (prior to the navigation).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60115: DevTools: tell agent it has client attached early (prior to the navigation). (Closed)

Created:
11 years, 8 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
brettw, yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: tell agent it has client attached early (prior to the navigation). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13237

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
M	chrome/browser/debugger/devtools_manager.h	View	1 2 5 6 7	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/debugger/devtools_manager.cc	View	1 2 3 4 5 6 7	5 chunks	+5 lines, -16 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View	1 2 5 6 7	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Hi Brett, I was looking for the ways to tell DevTools agent that it has ...

11 years, 8 months ago (2009-04-04 13:18:14 UTC) #1

brettw

11 years, 8 months ago (2009-04-06 14:36:33 UTC) #3

Hi Pavel,

What about NAV_ENTRY_PENDING? The NotificationController will send this one out
before telling the WebContents to navigate (see
NavigationController::LoadEntry). Hopefully this does what you need.

http://codereview.chromium.org/60115/diff/2001/2003
File chrome/browser/debugger/devtools_manager.h (right):

http://codereview.chromium.org/60115/diff/2001/2003#newcode62
Line 62: private:
You accidentally lost the space before the "private".

Expand Messages | Collapse Messages