wm: Fade screen on signout.

wm: Fade screen on signout.

Upon receiving a message from Chrome letting us know that
the user is signing out, we grab the pointer (to hide the
cursor) and make the screen fade quickly to black.

BUG=chromium-os:9915
TEST=added; also built an image and checked that the previous shutting-down animation still works pre- and post-login and that the new animation is shown when signing out

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=df1c098

[Chris Masone, 2010-12-29 23:06:55]

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc
File screen_locker_handler.cc (right):

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc#new...
screen_locker_handler.cc:342: snapshot_actor_->Move(0, 0, 0);
Seems like either you should assume Move and Scale will happen in here, or
assume they won't.  You seem to consistently follow up SetUsSnapshot with these
two calls when you use it below.

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc#new...
screen_locker_handler.cc:393: SetUpSnapshot();
It seems like you used to DO a slow animation and then do the fast animation
after, and now you don't.  Is that not so?  Or, is that now desired?

[Daniel Erat, 2010-12-29 23:20:24]

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc
File screen_locker_handler.cc (right):

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc#new...
screen_locker_handler.cc:342: snapshot_actor_->Move(0, 0, 0);
On 2010/12/29 23:06:55, Chris Masone wrote:
> Seems like either you should assume Move and Scale will happen in here, or
> assume they won't.  You seem to consistently follow up SetUsSnapshot with
these
> two calls when you use it below.

You're right; StartFastCloseAnimation()'s snapshot_actor_->Move(0, 0, 0) and
snapshot_actor_->Scale(1.0, 1.0, 0) are no-ops, since the actor is already being
configured identically.  I've deleted those.  I've also moved the calls in
StartSlowCloseAnimation() and StartFadeoutAnimation() into else blocks.

http://codereview.chromium.org/6011011/diff/4001/screen_locker_handler.cc#new...
screen_locker_handler.cc:393: SetUpSnapshot();
On 2010/12/29 23:06:55, Chris Masone wrote:
> It seems like you used to DO a slow animation and then do the fast animation
> after, and now you don't.  Is that not so?  Or, is that now desired?

I was just doing the slow animation to take the snapshot, since that's where the
code lived -- the faster animation added later in this method would replace the
slow one.  This change cleans things up by moving the snapshot-taking code into
a separate method.

[Chris Masone, 2010-12-29 23:28:54]

LGTM