Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: test/mjsunit/array-splice.js

Issue 601092: Adding checks for the cases when array grows too big. (Closed)
Patch Set: Turning checks into asserts as per Mad's suggestion Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.cc ('k') | test/mjsunit/array-unshift.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 assertFalse(array.hasOwnProperty(9)); 261 assertFalse(array.hasOwnProperty(9));
262 262
263 // and now check couple of indices above length. 263 // and now check couple of indices above length.
264 assertFalse(array.hasOwnProperty(10)); 264 assertFalse(array.hasOwnProperty(10));
265 assertFalse(array.hasOwnProperty(15)); 265 assertFalse(array.hasOwnProperty(15));
266 assertFalse(array.hasOwnProperty(31)); 266 assertFalse(array.hasOwnProperty(31));
267 assertFalse(array.hasOwnProperty(63)); 267 assertFalse(array.hasOwnProperty(63));
268 assertFalse(array.hasOwnProperty(2 << 32 - 1)); 268 assertFalse(array.hasOwnProperty(2 << 32 - 1));
269 } 269 }
270 })(); 270 })();
271
272
273 // Check the behaviour when approaching maximal values for length.
274 (function() {
275 for (var i = 0; i < 7; i++) {
276 try {
277 new Array((1 << 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5);
278 throw 'Should have thrown RangeError';
279 } catch (e) {
280 assertTrue(e instanceof RangeError);
281 }
282
283 // Check smi boundary
284 var bigNum = (1 << 30) - 3;
285 var array = new Array(bigNum);
286 array.splice(-1, 0, 1, 2, 3, 4, 5, 6, 7);
287 assertEquals(bigNum + 7, array.length);
288 }
289 })();
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | test/mjsunit/array-unshift.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698