Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8673)

Unified Diff: chrome/browser/translate/translate_manager_unittest.cc

Issue 601069: Fix the TranslateManager and unit-tests.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager_unittest.cc
===================================================================
--- chrome/browser/translate/translate_manager_unittest.cc (revision 38991)
+++ chrome/browser/translate/translate_manager_unittest.cc (working copy)
@@ -13,9 +13,6 @@
class TestTranslateManager : public TranslateManager {
public:
TestTranslateManager() {}
-
- protected:
- virtual bool TestEnabled() { return true; }
};
class TranslateManagerTest : public RenderViewHostTestHarness {
@@ -45,8 +42,24 @@
return true;
}
+ protected:
+ virtual void SetUp() {
+ RenderViewHostTestHarness::SetUp();
+
+ TranslateManager::set_test_enabled(true);
+ // This must be created after set_test_enabled() has been called to register
+ // notifications properly.
+ translate_manager_.reset(new TestTranslateManager());
+ }
+
+ virtual void TearDown() {
+ RenderViewHostTestHarness::TearDown();
+
+ TranslateManager::set_test_enabled(false);
+ }
+
private:
- TestTranslateManager translate_manager_;
+ scoped_ptr<TestTranslateManager> translate_manager_;
};
TEST_F(TranslateManagerTest, NormalTranslate) {
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698